Skip to content

[release/7.0] Fix missing using in Http3TimeoutTests #43321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 16, 2022

Conversation

github-actions[bot]
Copy link
Contributor

Backport of #43311 to release/7.0

/cc @dougbu @adityamandaleeka

{PR title}

Summary of the changes (Less than 80 chars)

Description

{Detail}

Fixes #{bug number} (in this specific format)

Customer Impact

{Justification}

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

When servicing release/2.1

  • Make necessary changes in eng/PatchConfig.props

@dougbu dougbu enabled auto-merge (squash) August 16, 2022 18:36
@dougbu dougbu added the tell-mode Indicates a PR which is being merged during tell-mode label Aug 16, 2022
@dougbu dougbu added this to the 7.0-rc2 milestone Aug 16, 2022
@halter73
Copy link
Member

@dougbu @wtgodbe @adityamandaleeka @Tratcher @captainsafia Do I have to do a second backport for #43302, or are we going to merge release/7.0-rc1 into release/7.0 and then merge that into main like we were talking about? Option 3 I think?

@wtgodbe
Copy link
Member

wtgodbe commented Aug 16, 2022

Does this need to be in rc1? If so this PR should be against that branch instead of this one. rc1 will auto-merge to 7.0 & 7.0 will auto-merge into main (option 3). If #43302 needs to be in rc1, you should manually port it there as well (or port it to this branch if it's for rc2).

@halter73
Copy link
Member

The rc1 PR for this change (#43312) has already been merged.

@wtgodbe
Copy link
Member

wtgodbe commented Aug 16, 2022

The rc1 PR for this change (#43312) has already been merged.

I see. In that case this PR isn't strictly necessary

@dougbu dougbu merged commit d86f3a4 into release/7.0 Aug 16, 2022
@dougbu dougbu deleted the backport/pr-43311-to-release/7.0 branch August 16, 2022 21:00
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants