-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Fix missing using in Http3TimeoutTests #43311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@dotnet/aspnet-build I assume this will be needed in the 7.0/RC1 branches as well. |
Use my PR instead lol! #43302 It was approved and green this morning. I changed some comments before 1pm and helix couldn't upload artifacts for the next 4 hours. |
Anything missing in release/7.0-rc1 or release/7.0 (for RC2) will need to be backported (using the bot) |
/backport to release/7.0-rc1 |
Started backporting to release/7.0-rc1: https://github.com/dotnet/aspnetcore/actions/runs/2865086295 |
Merged on red; the upload failures plaguing this and many other PRs are unrelated, and I didn't want everything to fail with this build issue when those PRs are retried. |
/backport to release/7.0 |
Started backporting to release/7.0: https://github.com/dotnet/aspnetcore/actions/runs/2870234158 |
Since we haven't configured anything for our build process yet (right @wtgodbe❔), also backported to release/7.0. |
Correct |
The build is broken after this PR went in: #43250
@BrennanConroy PTAL