[release/6.0] Check solution filters #37114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- backport of #36449 and #36756 Dougbu/check.solution.filters (#36449) * Check solution filters - confirm all mentioned projects are in AspNetCore.sln - clean up CodeCheck.ps1 - avoid aliases - rework long lines - avoid deprecated `dotnet run -p` - improve output a bit - correct whitespace - there can be only one - we have just one solution file - solution file should mention projects _once_ * Add missing projects to AspNetCore.sln - Middleware.slnf contained projects that no longer exist eg. NodeServices - VS also sorted the file and VS 2019 added ARM64 configurations - a few other solution filters still referenced removed and moved projects - correct capitalization in some solution filters Note: Unable to load some WiX projects in VS 2019 or _any_ in VS 2022 (WiX extension unavailable for 2022) * Remove trailing comma in a solution filter Put concatenated `string`s in parentheses (#36756) - follow-up to 779db7f - errors occur but point to the `+` sign instead of displaying real problem
dougbu
added
area-infrastructure
dougbu
requested review from
BrennanConroy,
halter73,
Pilchie and
Tratcher
as code owners
|
/fyi @dotnet/aspdoi |
dougbu
commented
Sep 30, 2021
| @@ -1634,7 +1634,7 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.AspNetCore.Http.R | |||
| EndProject | |||
| Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Logging.W3C.Sample", "src\Middleware\HttpLogging\samples\Logging.W3C.Sample\Logging.W3C.Sample.csproj", "{17459B97-1AA3-4154-83D3-C6BDC9FA3F85}" | |||
| EndProject | |||
| Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Microsoft.AspNetCore.Razor.Internal.SourceGenerator.Transport", "src\Razor\Microsoft.AspNetCore.Razor.Internal.SourceGenerator.Transport\Microsoft.AspNetCore.Razor.Internal.SourceGenerator.Transport.csproj", "{247E7B6F-FBA2-41A9-BA03-C7C4DF28091C}" | |||
| Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.AspNetCore.Razor.Internal.SourceGenerator.Transport", "src\Razor\Microsoft.AspNetCore.Razor.Internal.SourceGenerator.Transport\Microsoft.AspNetCore.Razor.Internal.SourceGenerator.Transport.csproj", "{247E7B6F-FBA2-41A9-BA03-C7C4DF28091C}" | |||
There was a problem hiding this comment.
To make conflict resolution easier, I used the project GUIDs from main for recently-updated projects. Microsoft.AspNetCore.Server.HttpSys.NonHelixTests and DelegationSite don't get new GUIDs because @Tratcher added them after the changes I'm backporting.
wtgodbe
approved these changes
Sep 30, 2021
ghost
added this to the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
strings in parentheses #36756Dougbu/check.solution.filters (#36449)
dotnet run -pNote: Unable to load some WiX projects in VS 2019 or any in VS 2022 (WiX extension unavailable for 2022)
Put concatenated
strings in parentheses (#36756)+sign instead of displaying real problem