Dougbu/check.solution.filters #36449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougbu
requested review from
BrennanConroy,
halter73,
Pilchie and
Tratcher
as code owners
Tratcher
approved these changes
Sep 13, 2021
|
What did you do to regenerate the .sln/.slnf files? Also, what do you mean by "we have just one solution file"? |
Pilchie
added
the
area-infrastructure
A combination of VS 2019 and 2022. WiX doesn't have a VS extension for I suspect people made manual changes to solution filters and neglected AspNetCore.sln for a bit.
CodeCheck.ps1 previously checked for solution files throughout the repo, wasting time and complicating the PowerShell. I cleaned that up. |
wtgodbe
approved these changes
Sep 13, 2021
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Merged
- confirm all mentioned projects are in AspNetCore.sln - clean up CodeCheck.ps1 - avoid aliases - rework long lines - avoid deprecated `dotnet run -p` - improve output a bit - correct whitespace - there can be only one - we have just one solution file - solution file should mention projects _once_
- Middleware.slnf contained projects that no longer exist eg. NodeServices - VS also sorted the file and VS 2019 added ARM64 configurations - a few other solution filters still referenced removed and moved projects - correct capitalization in some solution filters Note: Unable to load some WiX projects in VS 2019 or _any_ in VS 2022 (WiX extension unavailable for 2022)
dougbu
force-pushed
the
dougbu/check.solution.filters
branch
from
db027ff to
04f874f
Compare
ghost
added this to the
|
/backport to release/6.0 |
|
Started backporting to release/6.0: https://github.com/dotnet/aspnetcore/actions/runs/1240323991 |
|
@dougbu backporting to release/6.0 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: Check solution filters - confirm all mentioned projects are in AspNetCore.sln - clean up CodeCheck.ps1 - avoid aliases - rework long lines - avoid deprecated `dotnet run -p` - improve output a bit - correct whitespace - there can be only one - we have just one solution file - solution file should mention projects _once_
Applying: Add missing projects to AspNetCore.sln - Middleware.slnf contained projects that no longer exist eg. NodeServices - VS also sorted the file and VS 2019 added ARM64 configurations - a few other solution filters still referenced removed and moved projects - correct capitalization in some solution filters
error: sha1 information is lacking or useless (eng/scripts/CodeCheck.ps1).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 Add missing projects to AspNetCore.sln - Middleware.slnf contained projects that no longer exist eg. NodeServices - VS also sorted the file and VS 2019 added ARM64 configurations - a few other solution filters still referenced removed and moved projects - correct capitalization in some solution filters
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
dougbu
added a commit
that referenced
this pull request
Sep 29, 2021
- backport of #36449 and #36756 Dougbu/check.solution.filters (#36449) * Check solution filters - confirm all mentioned projects are in AspNetCore.sln - clean up CodeCheck.ps1 - avoid aliases - rework long lines - avoid deprecated `dotnet run -p` - improve output a bit - correct whitespace - there can be only one - we have just one solution file - solution file should mention projects _once_ * Add missing projects to AspNetCore.sln - Middleware.slnf contained projects that no longer exist eg. NodeServices - VS also sorted the file and VS 2019 added ARM64 configurations - a few other solution filters still referenced removed and moved projects - correct capitalization in some solution filters Note: Unable to load some WiX projects in VS 2019 or _any_ in VS 2022 (WiX extension unavailable for 2022) * Remove trailing comma in a solution filter Put concatenated `string`s in parentheses (#36756) - follow-up to 779db7f - errors occur but point to the `+` sign instead of displaying real problem
dougbu
added a commit
that referenced
this pull request
Sep 30, 2021
- backport of #36449 and #36756 Dougbu/check.solution.filters (#36449) * Check solution filters - confirm all mentioned projects are in AspNetCore.sln - clean up CodeCheck.ps1 - avoid aliases - rework long lines - avoid deprecated `dotnet run -p` - improve output a bit - correct whitespace - there can be only one - we have just one solution file - solution file should mention projects _once_ * Add missing projects to AspNetCore.sln - Middleware.slnf contained projects that no longer exist eg. NodeServices - VS also sorted the file and VS 2019 added ARM64 configurations - a few other solution filters still referenced removed and moved projects - correct capitalization in some solution filters Note: Unable to load some WiX projects in VS 2019 or _any_ in VS 2022 (WiX extension unavailable for 2022) * Remove trailing comma in a solution filter Put concatenated `string`s in parentheses (#36756) - follow-up to 779db7f - errors occur but point to the `+` sign instead of displaying real problem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dotnet run -pNote: Unable to load some WiX projects in VS 2019 or any in VS 2022 (WiX extension unavailable for 2022)