[release/6.0] Support more nonbubbling media events #36926
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ghost
added
the
SteveSandersonMS
approved these changes
Sep 24, 2021
|
@mkArtakMSFT This is approved and ready to merge (or be marked for auto-merge). Can you merge it please? |
|
/backport to release/6.0-rc2 |
|
Started backporting to release/6.0-rc2: https://github.com/dotnet/aspnetcore/actions/runs/1278560101 |
|
@SteveSandersonMS backporting to release/6.0-rc2 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: Support more nonbubbling media events
Applying: Update .js files
warning: Cannot merge binary files: src/Components/Web.JS/dist/Release/blazor.server.js (HEAD vs. Update .js files)
Using index info to reconstruct a base tree...
M src/Components/Web.JS/dist/Release/blazor.server.js
Falling back to patching base and 3-way merge...
Auto-merging src/Components/Web.JS/dist/Release/blazor.server.js
CONFLICT (content): Merge conflict in src/Components/Web.JS/dist/Release/blazor.server.js
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 Update .js files
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
Merged
mkArtakMSFT
added
Servicing-approved
|
Closing this out in favor of #37013. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #36925 to release/6.0
/cc @SteveSandersonMS
Description
Supports some additional nonbubbling DOM media events.
Customer Impact
Without this fix, certain DOM events on media elements can't fire Blazor's .NET event handlers. This specifically affects a key vendor demo scenario.
Regression?
Risk
This is just adding some new event names to a list that configures how we handle events. I've manually verified that none of these event names are also used by unrelated DOM elements in bubbling ways by checking each of them in https://developer.mozilla.org/en-US/docs/Web/Events.
Verification
Packaging changes reviewed?
Fixes #24323 and #20983