Skip to content

Support more nonbubbling media events #36925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 24, 2021

Conversation

SteveSandersonMS
Copy link
Member

Fixes #24323 and #20983, and required for new demos.

I don't propose to add further test coverage because:

  1. This is just adding more items to the list of nonbubbling events. We already have E2E tests showing that nonbubbling events are handled correctly when included in this list - see EventBubblingTest.cs.
  2. There are way more nonbubbling event types than we'd want to add individual tests for, and it would mostly be testing the browser itself, not Blazor, since Blazor has no specific behavior for any of them

@SteveSandersonMS SteveSandersonMS requested a review from a team as a code owner September 24, 2021 15:37
@ghost ghost added the area-blazor Includes: Blazor, Razor Components label Sep 24, 2021
@SteveSandersonMS SteveSandersonMS added this to the 6.0-rc2 milestone Sep 24, 2021
@SteveSandersonMS
Copy link
Member Author

/backport to release/6.0

@github-actions
Copy link
Contributor

Started backporting to release/6.0: https://github.com/dotnet/aspnetcore/actions/runs/1270462005

@mkArtakMSFT mkArtakMSFT added the Servicing-consider Shiproom approval is required for the issue label Sep 24, 2021
@ghost
Copy link

ghost commented Sep 24, 2021

Hi @SteveSandersonMS. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge.

To learn more about how to prepare a servicing PR click here.

@mkArtakMSFT mkArtakMSFT added Servicing-approved Shiproom has approved the issue and removed Servicing-consider Shiproom approval is required for the issue labels Sep 24, 2021
@SteveSandersonMS SteveSandersonMS enabled auto-merge (squash) September 24, 2021 16:44
@SteveSandersonMS SteveSandersonMS merged commit b507fc2 into main Sep 24, 2021
@SteveSandersonMS SteveSandersonMS deleted the stevesa/more-nonbubbling-events branch September 24, 2021 17:02
@ghost ghost modified the milestones: 6.0-rc2, 7.0-preview1 Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components Servicing-approved Shiproom has approved the issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Onended Event Blazor didn't fire.
3 participants