Skip to content

[release/6.0] Big-endian fixes: binary data in RenderBatch #36221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 7, 2021

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 7, 2021

Backport of #35714 to release/6.0

/cc @SteveSandersonMS @uweigand

Customer Impact

Prevents porting .NET Core to the IBM Z (s390x) architecture. See #35709

Testing

These are test-only changes.

Risk

Super low. These are test-only changes, and simple ones at that.

* Use little-endian accessors for RenderBatch binary data throughout

* Fixes part 3 of #35709
@github-actions github-actions bot requested a review from a team as a code owner September 7, 2021 10:47
@SteveSandersonMS SteveSandersonMS added the Servicing-consider Shiproom approval is required for the issue label Sep 7, 2021
@Pilchie Pilchie added the area-blazor Includes: Blazor, Razor Components label Sep 7, 2021
@TanayParikh
Copy link
Contributor

I believe we should be able to merge this without servicing. @dotnet/aspnet-build?

@dougbu
Copy link
Contributor

dougbu commented Sep 7, 2021

I believe we should be able to merge this without servicing. @dotnet/aspnet-build?

Unless we've heard different from Tactics (@wtgodbe, leads, @Pilchie❔), RC2 is still open and will remain open until we branch for that release. The branch is currently protected mainly because it's named release/*.

@wtgodbe wtgodbe merged commit 64aa83e into release/6.0 Sep 7, 2021
@wtgodbe wtgodbe deleted the backport/pr-35714-to-release/6.0 branch September 7, 2021 20:57
@ghost ghost added this to the 6.0-rc2 milestone Sep 7, 2021
@TanayParikh
Copy link
Contributor

Removing servicing label too in that case.

@wtgodbe wtgodbe removed the Servicing-consider Shiproom approval is required for the issue label Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants