Skip to content

Conversation

uweigand
Copy link
Contributor

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

PR Title
Big-endian fixes: binary data in RenderBatch

PR Description

* Use little-endian accessors for RenderBatch binary data throughout

* Fixes part 3 of dotnet#35709
@uweigand uweigand requested a review from a team as a code owner August 25, 2021 17:18
@ghost ghost added area-blazor Includes: Blazor, Razor Components community-contribution Indicates that the PR has been added by a community member labels Aug 25, 2021
@mkArtakMSFT
Copy link
Contributor

Thanks for your contribution. @SteveSandersonMS can you please review this? Thanks!

Copy link
Member

@SteveSandersonMS SteveSandersonMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Just FYI, we are going to remove Ignitor entirely soon, as it's now replaced by a more complete set of E2E tests. But in the meantime we can merge your change to it in case it helps you, since it doesn't seem to have any drawbacks for anyone else.

@SteveSandersonMS SteveSandersonMS merged commit 0f8675f into dotnet:main Sep 7, 2021
@uweigand
Copy link
Contributor Author

uweigand commented Sep 7, 2021

Thanks, @SteveSandersonMS! Could this also go into the .NET 6 branch to fix the test suite failures on s390x there?

@SteveSandersonMS
Copy link
Member

/backport to release/6.0

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2021

Started backporting to release/6.0: https://github.com/dotnet/aspnetcore/actions/runs/1209108231

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants