Added coverage for developer exception page #35778
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added tests to verify that the developer exception page is on in development.
ghost
added
the
|
@Pilchie I plan to backport this to rc2. It's adding missing test coverage, no product changes. |
BrennanConroy
approved these changes
Aug 26, 2021
src/DefaultBuilder/test/Microsoft.AspNetCore.Tests/WebApplicationTests.cs
Show resolved
Hide resolved
src/DefaultBuilder/test/Microsoft.AspNetCore.Tests/WebApplicationTests.cs
Outdated
Show resolved
Hide resolved
|
Oh, remove the comment too |
|
No problem - RC2 doesn't require approval yet, and even if it did, test only stuff generally is tell mode. |
|
/backport to release/6.0 |
|
Started backporting to release/6.0: https://github.com/dotnet/aspnetcore/actions/runs/1171600083 |
davidfowl
added a commit
that referenced
this pull request
Sep 12, 2021
amcasey
added
area-minimal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35423