Skip to content

Missing test coverage in WebApplicationBuilder #35423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
BrennanConroy opened this issue Aug 17, 2021 · 0 comments · Fixed by #35778
Closed

Missing test coverage in WebApplicationBuilder #35423

BrennanConroy opened this issue Aug 17, 2021 · 0 comments · Fixed by #35778
Assignees
@davidfowl
Labels
area-hosting Includes Hosting area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc feature-minimal-hosting old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels
Milestone
6.0-rc2

Comments

@BrennanConroy
Copy link
Member

Noticed there were no tests for the DeveloperExceptionPage added in the WebApplicationBuilder

aspnetcore/src/DefaultBuilder/src/WebApplicationBuilder.cs

Line 192 in 5a04636

app.UseDeveloperExceptionPage();

Didn't write any because I'm trying to get in some more urgent changes right now.
@BrennanConroy BrennanConroy added the old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels label Aug 17, 2021
@BrennanConroy BrennanConroy mentioned this issue Aug 17, 2021
Merged
@davidfowl davidfowl self-assigned this Aug 26, 2021
@davidfowl davidfowl added this to the 6.0-rc2 milestone Aug 26, 2021
@davidfowl davidfowl mentioned this issue Aug 26, 2021
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Sep 25, 2021
@amcasey amcasey added area-hosting Includes Hosting area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc labels Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@davidfowl davidfowl

Labels
area-hosting Includes Hosting area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc feature-minimal-hosting old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels
Projects
None yet
Milestone
6.0-rc2
Development

Successfully merging a pull request may close this issue.

Added coverage for developer exception page dotnet/aspnetcore
3 participants
@davidfowl @BrennanConroy @amcasey