-
Notifications
You must be signed in to change notification settings - Fork 10.3k
[release/3.1] Clean out Ubuntu 16.04 testing #33052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,24 +18,16 @@ | |
| <HelixAvailableTargetQueue Include="Windows.81.Amd64.Open" Platform="Windows" /> | ||
| <HelixAvailableTargetQueue Include="Windows.7.Amd64.Open" Platform="Windows" /> | ||
| <HelixAvailableTargetQueue Include="Windows.10.Amd64.EnterpriseRS3.ASPNET.Open" Platform="Windows" EnableByDefault="false" /> | ||
| <HelixAvailableTargetQueue Include="OSX.1013.Amd64.Open" Platform="OSX" /> | ||
| <HelixAvailableTargetQueue Include="Ubuntu.1604.Amd64.Open" Platform="Linux" /> | ||
| <HelixAvailableTargetQueue Include="OSX.1014.Amd64.Open" Platform="OSX" /> | ||
| <HelixAvailableTargetQueue Include="Ubuntu.1804.Amd64.Open" Platform="Linux" /> | ||
| <HelixAvailableTargetQueue Include="Centos.7.Amd64.Open" Platform="Linux" /> | ||
| <HelixAvailableTargetQueue Include="Debian.8.Amd64.Open" Platform="Linux" /> | ||
dougbu marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| <HelixAvailableTargetQueue Include="Debian.9.Amd64.Open" Platform="Linux" /> | ||
| <HelixAvailableTargetQueue Include="Redhat.7.Amd64.Open" Platform="Linux" /> | ||
| <HelixAvailableTargetQueue Include="(Fedora.28.Amd64.Open)Ubuntu.1604[email protected]/dotnet-buildtools/prereqs:fedora-28-helix-09ca40b-20190508143249" Platform="Linux" /> | ||
| <HelixAvailableTargetQueue Include="(Fedora.33.Amd64.Open)Ubuntu.1804[email protected]/dotnet-buildtools/prereqs:fedora-33-helix-20210120000908-a9df267" Platform="Linux" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup Condition="'$(IsWindowsOnlyTest)' != 'true' AND '$(TargetArchitecture)' == 'arm64'"> | ||
| <!-- arm64 queues --> | ||
| <HelixAvailableTargetQueue Include="(Debian.9.Arm64.Open)[email protected]/dotnet-buildtools/prereqs:debian-9-helix-arm64v8-a12566d-20190807161036" Platform="Linux" /> | ||
|
|
||
| <!-- Need to resolve permission issues on this docker queue | ||
| <HelixAvailableTargetQueue Include="(Alpine.38.Arm64)[email protected]/dotnet-buildtools/prereqs:alpine-3.8-helix-arm64v8-46e69dd-20190327215724" Platform="Linux" /> | ||
| <HelixAvailableTargetQueue Include="(Ubuntu-1804.Arm64.Open)[email protected]/dotnet-buildtools/prereqs:ubuntu-18.04-helix-arm64v8-6f28fa9-20190606004102" Platform="Linux" /> | ||
| --> | ||
| <HelixAvailableTargetQueue Include="(Debian.9.Arm64.Open)[email protected]/dotnet-buildtools/prereqs:debian-9-helix-arm64v8-a12566d-20190807161036" Platform="Linux" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup Condition="'$(IsWindowsOnlyTest)' == 'true'"> | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We test on this plus Windows.10.Amd64.ClientRS4.VS2017.Open. Should I upgrade to more recent Windows.10 builds❔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like we should try to leave the matrix alone on older releases shouldn't we? Otherwise we might just create extra test failures/differences to investigate across branches? Like maybe the idea would be we only upgrade when required, like with 16.04 being EOL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HaoK overall, are you suggesting I leave the Windows queues alone and do not add OSX 11.00 or Ubuntu 20.04 but clean up or upgrade from CentOS 7, Debian 8, Fedora 28, OSX 10.13, and Ubuntu 16.04❔
(I would pick Ubuntu 18.04 over 20.4 at the moment because it's more commonly used. EOL is 2 years in the future.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, I'd basically only update 16.04 -> 18.04 and just drop Centos7/Debian8/Fedora28. If we don't have to update OSX 1013 -> 1014, or any windows versions, I wouldn't do either.
Given that we aren't working actively in this branch, minimizing churn with the queues seems better than being proactive to update things (assuming things are mostly working on the current queues).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the oldest Win10 version officially supported by dotnet? We should at least test the oldest and newest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Pilchie @halter73 is there a Windows 10 or OSX support matrix for our servicing releases somewhere❔