-
Notifications
You must be signed in to change notification settings - Fork 10.3k
[release/3.1] Clean out Ubuntu 16.04 testing #33052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dougbu
commented
May 26, 2021
- a variant of Clean out Ubuntu 16.04 testing #32894
- use Ubuntu 18.04 agents for testing in Docker containers on Helix
- remove use of old Centos and Debian queues
- move to newer OSX.1014.Amd64.Open queue and Fedora.33.Amd64.Open Docker image
- add a couple of queues we test against in 'main'
- a variant of #32894 - use Ubuntu 18.04 agents for testing in Docker containers on Helix - remove use of old Centos and Debian queues - move to newer OSX.1014.Amd64.Open queue and Fedora.33.Amd64.Open Docker image - add a couple of queues we test against in 'main'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of questions…
@@ -18,23 +18,22 @@ | |||
<HelixAvailableTargetQueue Include="Windows.81.Amd64.Open" Platform="Windows" /> | |||
<HelixAvailableTargetQueue Include="Windows.7.Amd64.Open" Platform="Windows" /> | |||
<HelixAvailableTargetQueue Include="Windows.10.Amd64.EnterpriseRS3.ASPNET.Open" Platform="Windows" EnableByDefault="false" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We test on this plus Windows.10.Amd64.ClientRS4.VS2017.Open. Should I upgrade to more recent Windows.10 builds❔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like we should try to leave the matrix alone on older releases shouldn't we? Otherwise we might just create extra test failures/differences to investigate across branches? Like maybe the idea would be we only upgrade when required, like with 16.04 being EOL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HaoK overall, are you suggesting I leave the Windows queues alone and do not add OSX 11.00 or Ubuntu 20.04 but clean up or upgrade from CentOS 7, Debian 8, Fedora 28, OSX 10.13, and Ubuntu 16.04❔
(I would pick Ubuntu 18.04 over 20.4 at the moment because it's more commonly used. EOL is 2 years in the future.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, I'd basically only update 16.04 -> 18.04 and just drop Centos7/Debian8/Fedora28. If we don't have to update OSX 1013 -> 1014, or any windows versions, I wouldn't do either.
Given that we aren't working actively in this branch, minimizing churn with the queues seems better than being proactive to update things (assuming things are mostly working on the current queues).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the oldest Win10 version officially supported by dotnet? We should at least test the oldest and newest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- don't add OSX 11.00 or Ubuntu 20.04 queues - leave Ubuntu 16.04 removal - also use Ubuntu 18.04 base for Debian 9 ARM64 testing - leave OSX 10.13 -> 10.14 and Fedora 28 -> 33 upgrades nit: remove old commented-out mention of Alpine.38.Arm64
Hmm, @HaoK and @dotnet/aspnet-build this change may be completely irrelevant. I can't find a pipeline associated w/ our helix-test.yml file and ci.yml doesn't mention Helix at all. I am no longer sure we test using Helix anywhere w/ the release/3.1 branch. Did we remove it at some point or perhaps never finish adding it❔ |
Right, that's what I was sorta asking a few weeks ago, I am pretty sure 5.0 was the first time we actually turned helix on for real, 3.1 was as manual/optional thing I think |