Skip to content

[release/3.1] Update cert then rebrand #33034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 1, 2021
Merged

[release/3.1] Update cert then rebrand #33034

merged 6 commits into from
Jun 1, 2021

Conversation

github-actions[bot]
Copy link
Contributor

Backport of #32812 to release/3.1

/cc @HaoK

Customer Impact

Testing

Risk

@github-actions github-actions bot requested a review from Tratcher as a code owner May 26, 2021 09:47
@Pilchie Pilchie added the area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer label May 26, 2021
dougbu
dougbu reviewed May 26, 2021
View reviewed changes
src/Security/Authentication/test/CertificateTests.cs Outdated
@@ -179,7 +179,8 @@ public async Task VerifyExpiredSelfSignedPassesIfDateRangeValidationIsDisabled()
Assert.Equal(HttpStatusCode.OK, response.StatusCode);
}

[Fact]
[ConditionalFact]
[SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/32813")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test ran in CI build. Why❔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://dev.azure.com/dnceng/public/_build/results?buildId=1157051&view=ms.vss-test-web.build-test-results-tab&runId=34941486&resultId=101982&paneView=debug

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More proof that we weren't only running things on helix yet... SkipOnHelix has no effect on azdo jobs. The results file name is not the helix queue form either

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skipping on linux since for some reason this test is failing only on ubuntu with the new cert

dougbu
dougbu approved these changes May 26, 2021
View reviewed changes
Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFM if you can get CI build working

@dougbu dougbu mentioned this pull request May 26, 2021
Closed
@HaoK
Copy link
Member

HaoK commented May 27, 2021

Things are green now @dougbu not sure if I'm supposed to do anything else from here to get this in, but this should address the test failures in release/3.1

@dougbu
Copy link
Contributor

dougbu commented May 27, 2021

Nothing more to do 'til the release/3.1 branch is branded for 3.1.17. @dotnet/aspnet-build will get this in at the right time.

@dougbu dougbu added this to the 3.1.17 milestone May 27, 2021
@dougbu
Copy link
Contributor

dougbu commented May 27, 2021

(We may need to do branding in this PR to avoid CI failures in that work.)

@dougbu dougbu added the tell-mode Indicates a PR which is being merged during tell-mode label May 27, 2021
@dougbu
Copy link
Contributor

dougbu commented May 27, 2021

/fyi @Pilchie I marked this as tell-mode

@dougbu dougbu mentioned this pull request May 27, 2021
Merged
@wtgodbe
Copy link
Member

wtgodbe commented Jun 1, 2021

FYI @dotnet/aspnet-build I'm doing branding in this PR

@dougbu dougbu changed the title [release/3.1] Update cert that became valid and broke tests [release/3.1] Update cert then rebrand Jun 1, 2021
@dougbu
Copy link
Contributor

dougbu commented Jun 1, 2021

/fyi I renamed the PR to cover what's going on

@wtgodbe wtgodbe merged commit 2ba4c96 into release/3.1 Jun 1, 2021
@wtgodbe wtgodbe deleted the backport/pr-32812-to-release/3.1 branch June 1, 2021 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HaoK HaoK HaoK left review comments

@dougbu dougbu dougbu approved these changes

@Tratcher Tratcher Awaiting requested review from Tratcher Tratcher is a code owner

Assignees
No one assigned
Labels
area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Milestone
3.1.17
Development

Successfully merging this pull request may close these issues.
4 participants
@HaoK @dougbu @wtgodbe @Pilchie