Skip to content

Include platform in SharedFx bundle name #32778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2021
+2 −2
Merged

Include platform in SharedFx bundle name #32778

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Installers/Windows/SharedFrameworkBundle/SharedFrameworkBundle.wixproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,8 @@

<BundleNameShort>Microsoft ASP.NET Core $(PackageBrandingVersion)</BundleNameShort>
<BundleNameSub>Shared Framework</BundleNameSub>
<BundleName>$(BundleNameShort) - $(BundleNameSub)</BundleName>
<BundleNameFull>$(BundleName) ($(Platform))</BundleNameFull>
<BundleName>$(BundleNameShort) - $(BundleNameSub) ($(Platform))</BundleName>
<BundleNameFull>$(BundleName)</BundleNameFull>
<BundleRegName>$(BundleNameFull)</BundleRegName>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why keep all of $(BundleName), $(BundleNameFull) and $(BundleRegName) if their values should be the same❔

More importantly, don't we have the same problem w/ the Windows Hosting bundle https://github.com/dotnet/aspnetcore/blob/52eff90fbcfca39b7eb58baad597df6a99a542b0/src/Installers/Windows/WindowsHostingBundle/WindowsHostingBundle.wixproj#L84-L85❔

Copy link
Member Author

@wtgodbe wtgodbe May 18, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess they correspond to specific wix properties - we could just have one msbuild property that the .wxs file references three times, but I don't think it matters too much. As for the hosting bundle, that's platform-agnostic, so it doesn't need to specify what platform it's for in the name.


<BundleManufacturer>Microsoft Corporation</BundleManufacturer>
Expand Down