Include platform in SharedFx bundle name #32778
Conversation
ghost
added
the
area-infrastructure
|
|
| <BundleName>$(BundleNameShort) - $(BundleNameSub)</BundleName> | ||
| <BundleNameFull>$(BundleName) ($(Platform))</BundleNameFull> | ||
| <BundleName>$(BundleNameShort) - $(BundleNameSub) ($(Platform))</BundleName> | ||
| <BundleNameFull>$(BundleName)</BundleNameFull> | ||
| <BundleRegName>$(BundleNameFull)</BundleRegName> |
There was a problem hiding this comment.
Why keep all of $(BundleName), $(BundleNameFull) and $(BundleRegName) if their values should be the same❔
More importantly, don't we have the same problem w/ the Windows Hosting bundle https://github.com/dotnet/aspnetcore/blob/52eff90fbcfca39b7eb58baad597df6a99a542b0/src/Installers/Windows/WindowsHostingBundle/WindowsHostingBundle.wixproj#L84-L85❔
There was a problem hiding this comment.
I guess they correspond to specific wix properties - we could just have one msbuild property that the .wxs file references three times, but I don't think it matters too much. As for the hosting bundle, that's platform-agnostic, so it doesn't need to specify what platform it's for in the name.
|
/backport to release/3.1 |
|
/backport to release/5.0 |
|
Started backporting to release/3.1: https://github.com/dotnet/aspnetcore/actions/runs/872127368 |
|
Hi @github-actions[bot]. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
|
Started backporting to release/5.0: https://github.com/dotnet/aspnetcore/actions/runs/872127584 |
|
Hi @github-actions[bot]. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
Fixes #32708
I'll use this PR as a guinea pig for the backport bot introduced by #32777
Internal build to grab installers for validation: https://dev.azure.com/dnceng/internal/_build/results?buildId=1142108&view=results