Skip to content

[release/5.0] Don't include RuntimeList.xml in sharedFx archive #29109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 13, 2021
Merged

[release/5.0] Don't include RuntimeList.xml in sharedFx archive #29109

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
57869f6
Don't include RuntimeList.xml in sharedFx archive
wtgodbe Jan 6, 2021
9c20d21
Don't output RuntimeList.xml to SharedFx dir
wtgodbe Jan 6, 2021
ba767fd
Add comment
wtgodbe Jan 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ This package is an internal implementation of the .NET Core SDK and is not meant
<LocalInstallationOutputPath>$(LocalDotNetRoot)$(SharedRuntimeSubPath)</LocalInstallationOutputPath>

<FrameworkListFileName>RuntimeList.xml</FrameworkListFileName>
<FrameworkListOutputPath>$(SharedFxLayoutTargetDir)$(FrameworkListFileName)</FrameworkListOutputPath>
<FrameworkListOutputPath>$(ArtifactsObjDir)$(FrameworkListFileName)</FrameworkListOutputPath>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: A comment here indicating we don't always want the RuntimeList.xml file in the layout might help.


<InternalArchiveOutputFileName>$(InternalInstallerBaseName)-$(PackageVersion)-$(TargetRuntimeIdentifier)$(ArchiveExtension)</InternalArchiveOutputFileName>
<InternalArchiveOutputPath>$(InstallersOutputPath)$(InternalArchiveOutputFileName)</InternalArchiveOutputPath>
Expand Down Expand Up @@ -545,7 +545,8 @@ This package is an internal implementation of the .NET Core SDK and is not meant
RootAttributes="@(FrameworkListRootAttributes)" />

<ItemGroup>
<RuntimePackContent Include="$(FrameworkListOutputPath)" PackagePath="$(ManifestsPackagePath)" />
<!-- We only need RuntimeList.xml in the .nupkg, so we intentionally do not include it in the archives -->
<_PackageFiles Include="$(FrameworkListOutputPath)" PackagePath="$(ManifestsPackagePath)" />
<_PackageFiles Include="@(RuntimePackContent)" />
</ItemGroup>
</Target>
Expand Down