[release/5.0] Don't include RuntimeList.xml in sharedFx archive #29109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
feature-platform
Actually the original issue is bogus - It's always been the case that the public archive doesn't have the file, and the internal archive does - there wasn't an intermediate change that originally "fixed" #27670. I didn't know that when I filed the original issue. I'll edit the issue to reflect the actual state of things |
|
I've looked at the outputs and confirmed that the |
dougbu
approved these changes
Jan 7, 2021
| @@ -154,7 +154,7 @@ This package is an internal implementation of the .NET Core SDK and is not meant | |||
| <LocalInstallationOutputPath>$(LocalDotNetRoot)$(SharedRuntimeSubPath)</LocalInstallationOutputPath> | |||
|
|
|||
| <FrameworkListFileName>RuntimeList.xml</FrameworkListFileName> | |||
| <FrameworkListOutputPath>$(SharedFxLayoutTargetDir)$(FrameworkListFileName)</FrameworkListOutputPath> | |||
| <FrameworkListOutputPath>$(ArtifactsObjDir)$(FrameworkListFileName)</FrameworkListOutputPath> | |||
There was a problem hiding this comment.
nit: A comment here indicating we don't always want the RuntimeList.xml file in the layout might help.
wtgodbe
added
the
tell-mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #27670
dotnet/runtime and dotnet/windowsdesktop don't include this file in their SharedFx archives. Looking at the SDK archive, it contains a
runtimelist.xmlfor aspnetcore, but not for runtime or windowsdesktop. We should remove the file from our archive, but keep it in our .nupkg.