Fix template tests #27948
Fix template tests #27948
Conversation
ghost
added
the
area-mvc
|
Looks like the magic sauce that was needed was a passing ChromeOptions --ignore-certificate-errors |
|
@HaoK What was going on here? I assume that some certificate errors caused the pages not to load which caused the "did page load" test that we have on most cases? |
|
I'm not sure what changed to cause things to break completely, it looks like there was already code that tried to handle certificate errors with only the edge driver. It finally was obvious what was going on when I ran 'dotnet dev-certs https --trust' manually on my machine as an random attempt to see if that would help, that seemed to unblock the tests, so then just disabling the warning did the trick. Maybe various chrome updates/selenium updates resulted in the behavior changing over time, it looks like these tests fail every 3 ci runs generally, so my guess is there's something external that affects the dev cert trust that only runs once in a while. Regardless, this option seems to make the tests independent of whether the dev cert is trusted now |
|
The good news is that the localdb auth tests were failing 100% of the time without this change so this is definitely helping |
|
@HaoK I see. Nice find. Thanks for the explanation. |
| @@ -27,7 +27,6 @@ public BlazorServerTemplateTest(ProjectFactoryFixture projectFactory, BrowserFix | |||
| public Project Project { get; private set; } | |||
|
|
|||
| [Fact] | |||
| [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/20172")] | |||
There was a problem hiding this comment.
nit: you aren't supposed to remove this after potentially fixing a test, you should wait at least 30 days and whoever is on build ops will eventually remove it from quarantine if it's been passing
No description provided.