Skip to content

Fix template tests #27948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 20, 2020
Merged

Fix template tests #27948

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
17cfa55
Turn on tests for investigation
HaoK Nov 18, 2020
8c8909e
Try to bypass SSL warning
HaoK Nov 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/ProjectTemplates/BlazorTemplates.Tests/BlazorServerTemplateTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ public BlazorServerTemplateTest(ProjectFactoryFixture projectFactory, BrowserFix
public Project Project { get; private set; }

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/20172")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: you aren't supposed to remove this after potentially fixing a test, you should wait at least 30 days and whoever is on build ops will eventually remove it from quarantine if it's been passing

public async Task BlazorServerTemplateWorks_NoAuth()
{
// Additional arguments are needed. See: https://github.com/dotnet/aspnetcore/issues/24278
Expand Down Expand Up @@ -88,7 +87,6 @@ public async Task BlazorServerTemplateWorks_NoAuth()
[Theory]
[InlineData(true)]
[InlineData(false)]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/27376")]
public async Task BlazorServerTemplateWorks_IndividualAuth(bool useLocalDB)
{
// Additional arguments are needed. See: https://github.com/dotnet/aspnetcore/issues/24278
Expand Down
9 changes: 2 additions & 7 deletions src/ProjectTemplates/BlazorTemplates.Tests/BlazorWasmTemplateTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ public override Task InitializeAsync()
return InitializeAsync(isolationContext: Guid.NewGuid().ToString());
}

[Fact(Skip = "Certificate issue: https://github.com/dotnet/aspnetcore/issues/25826")]
[Fact]
public async Task BlazorWasmStandaloneTemplate_Works()
{
// Additional arguments are needed. See: https://github.com/dotnet/aspnetcore/issues/24278
Expand Down Expand Up @@ -80,7 +80,6 @@ public async Task BlazorWasmStandaloneTemplate_Works()
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/20172")]
public async Task BlazorWasmHostedTemplate_Works()
{
// Additional arguments are needed. See: https://github.com/dotnet/aspnetcore/issues/24278
Expand Down Expand Up @@ -137,7 +136,6 @@ private static async Task AssertCompressionFormat(AspNetProcess aspNetProcess, s
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/23992")]
public async Task BlazorWasmStandalonePwaTemplate_Works()
{
// Additional arguments are needed. See: https://github.com/dotnet/aspnetcore/issues/24278
Expand Down Expand Up @@ -178,7 +176,7 @@ public async Task BlazorWasmStandalonePwaTemplate_Works()
}
}

[Fact(Skip = "Certificate issue: https://github.com/dotnet/aspnetcore/issues/25826")]
[Fact]
public async Task BlazorWasmHostedPwaTemplate_Works()
{
// Additional arguments are needed. See: https://github.com/dotnet/aspnetcore/issues/24278
Expand Down Expand Up @@ -262,7 +260,6 @@ private void ValidateAppWorksOffline(Project project, string listeningUri, bool
}

[ConditionalFact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/23992")]
// LocalDB doesn't work on non Windows platforms
[OSSkipCondition(OperatingSystems.Linux | OperatingSystems.MacOSX)]
public Task BlazorWasmHostedTemplate_IndividualAuth_Works_WithLocalDB()
Expand All @@ -271,7 +268,6 @@ public Task BlazorWasmHostedTemplate_IndividualAuth_Works_WithLocalDB()
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/23992")]
public Task BlazorWasmHostedTemplate_IndividualAuth_Works_WithOutLocalDB()
{
return BlazorWasmHostedTemplate_IndividualAuth_Works(false);
Expand Down Expand Up @@ -346,7 +342,6 @@ private async Task BlazorWasmHostedTemplate_IndividualAuth_Works(bool useLocalDb
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/23639")]
public async Task BlazorWasmStandaloneTemplate_IndividualAuth_Works()
{
// Additional arguments are needed. See: https://github.com/dotnet/aspnetcore/issues/24278
Expand Down
1 change: 1 addition & 0 deletions src/Shared/E2ETesting/BrowserFixture.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,7 @@ private async Task DeleteBrowserUserProfileDirectoriesAsync()
}

opts.AddArgument("--no-sandbox");
opts.AddArgument("--ignore-certificate-errors");

// Log errors
opts.SetLoggingPreference(LogType.Browser, LogLevel.All);
Expand Down