-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Investigate flaky blazor templates #26389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We should probably re-enable the tests for 5.0 |
Okay I'll file a PR with just the revert of the skip tests for 5.0 |
Looks like its only disabled in master, since the fix came from 3.1 https://github.com/dotnet/aspnetcore/blob/release/5.0/src/Shared/E2ETesting/E2ETesting.props looks fine so we are good in 5.0 |
Yeah this is why i was confused since the tests were running in 5.0 PRs when I was investigating |
@javiercn is it normal to sometimes get empty screenshots from the selenium captures? The Templates.Test.BlazorWasmTemplateTest.BlazorWasmStandaloneTemplate_IndividualAuth_Works png appears to be blank to me :( |
Note these tests seem to all fail together, i.e. from https://dev.azure.com/dnceng/public/_build/results?buildId=849186&view=ms.vss-test-web.build-test-results-tab&runId=27060606&resultId=100004&paneView=debug they all pass for two builds, then all of them fail, which seems like something might be getting borked at the infrastructure level |
Possible issue
|
Ah that could explain it, @Tratcher any ideas what might cause this cert exception? Or how to dig deeper into this? Its happen fairly reliability, in that I hit it within 3 builds today |
https://docs.microsoft.com/en-us/windows/win32/secauthn/schannel-error-codes-for-tls-and-ssl-alerts Which could be any of these: Are these tests relying on the dev cert or are they using a specific test cert? |
These are just the template tests so the dev cert, they just do new template build and run without any extra operations I don't think. |
Could this mean the dev cert wasn't installed properly some % of the time? |
Seems likely, or it's being messed up by another test. Tests using the dev cert should:
Or, we should make these tests not use the dev cert. |
Do we have any tests that currently check if the dev cert is valid? Aka is there any code I can steal for that? |
Rebased version continuing in #27948 |
For: #23992