Skip to content

Investigate flaky blazor templates #26389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 19 commits into from
Closed

Investigate flaky blazor templates #26389

wants to merge 19 commits into from

Conversation

HaoK
Copy link
Member

@HaoK HaoK commented Sep 28, 2020

For: #23992

@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Sep 28, 2020
@HaoK HaoK linked an issue Sep 28, 2020 that may be closed by this pull request
@BrennanConroy
Copy link
Member

We should probably re-enable the tests for 5.0

@HaoK
Copy link
Member Author

HaoK commented Oct 5, 2020

Okay I'll file a PR with just the revert of the skip tests for 5.0

@HaoK
Copy link
Member Author

HaoK commented Oct 5, 2020

Looks like its only disabled in master, since the fix came from 3.1 https://github.com/dotnet/aspnetcore/blob/release/5.0/src/Shared/E2ETesting/E2ETesting.props looks fine so we are good in 5.0

@HaoK
Copy link
Member Author

HaoK commented Oct 5, 2020

Yeah this is why i was confused since the tests were running in 5.0 PRs when I was investigating

@HaoK
Copy link
Member Author

HaoK commented Oct 5, 2020

@javiercn is it normal to sometimes get empty screenshots from the selenium captures? The Templates.Test.BlazorWasmTemplateTest.BlazorWasmStandaloneTemplate_IndividualAuth_Works png appears to be blank to me :(

@HaoK
Copy link
Member Author

HaoK commented Oct 12, 2020

Note these tests seem to all fail together, i.e. from https://dev.azure.com/dnceng/public/_build/results?buildId=849186&view=ms.vss-test-web.build-test-results-tab&runId=27060606&resultId=100004&paneView=debug they all pass for two builds, then all of them fail, which seems like something might be getting borked at the infrastructure level

@BrennanConroy
Copy link
Member

Possible issue

dbug: Microsoft.AspNetCore.Server.Kestrel.Https.Internal.HttpsConnectionMiddleware[1]
              Failed to authenticate HTTPS connection.
              System.Security.Authentication.AuthenticationException: Authentication failed, see inner exception.
               ---> System.ComponentModel.Win32Exception (0x80090327): An unknown error occurred while processing the certificate.
                 --- End of inner exception stack trace ---
                 at System.Net.Security.SslStream.ForceAuthenticationAsync[TIOAdapter](TIOAdapter adapter, Boolean receiveFirst, Byte[] reAuthenticationData, Boolean isApm)
                 at Microsoft.AspNetCore.Server.Kestrel.Https.Internal.HttpsConnectionMiddleware.OnConnectionAsync(ConnectionContext context)

@HaoK
Copy link
Member Author

HaoK commented Oct 12, 2020

Ah that could explain it, @Tratcher any ideas what might cause this cert exception? Or how to dig deeper into this? Its happen fairly reliability, in that I hit it within 3 builds today

@Tratcher
Copy link
Member

https://docs.microsoft.com/en-us/windows/win32/secauthn/schannel-error-codes-for-tls-and-ssl-alerts
SEC_E_CERT_UNKNOWN
0x80090327

Which could be any of these:
TLS1_ALERT_BAD_CERTIFICATE
TLS1_ALERT_UNSUPPORTED_CERT
TLS1_ALERT_CERTIFICATE_UNKNOWN

Are these tests relying on the dev cert or are they using a specific test cert?

@HaoK
Copy link
Member Author

HaoK commented Oct 12, 2020

These are just the template tests so the dev cert, they just do new template build and run without any extra operations I don't think.

@HaoK
Copy link
Member Author

HaoK commented Oct 12, 2020

Could this mean the dev cert wasn't installed properly some % of the time?

@Tratcher
Copy link
Member

Seems likely, or it's being messed up by another test. Tests using the dev cert should:

  • Check it before starting the test
  • Not run in parallel in case they try to fix the cert in parallel

Or, we should make these tests not use the dev cert.

@HaoK
Copy link
Member Author

HaoK commented Oct 12, 2020

Do we have any tests that currently check if the dev cert is valid? Aka is there any code I can steal for that?

@Tratcher
Copy link
Member

@javiercn ?

@HaoK
Copy link
Member Author

HaoK commented Nov 18, 2020

Rebased version continuing in #27948

@HaoK HaoK closed this Nov 18, 2020
@HaoK HaoK deleted the haok/wasmtemp branch December 17, 2020 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky tests in BlazorWasmTemplateTest
3 participants