!!! Correct condition controlling public API analysis !!!
#26797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- #26785 demonstrated analyzers were inoperable
ghost
added
the
area-infrastructure
|
@Pilchie is this too late for tell mode❔ |
|
I think we can still get it, but obviously the errors will need to be fixed. Do we know if this is new API surface since the previous change? |
|
I'm working on the errors. Appears changes are primarily due to nullable additions since #25662. I'm not sure that's the whole story however. |
- three Components files were missing `#nullable enable` - `nullable` annotations missing or out-of-date elsewhere
dougbu
requested review from
BrennanConroy,
halter73,
javiercn,
jkotalik,
SteveSandersonMS,
Tratcher and
a team
as code owners
- do not warn about unused files
wtgodbe
approved these changes
Oct 12, 2020
|
Whichever is comfortable is fine with me. |
TanayParikh
added a commit
that referenced
this pull request
Oct 14, 2020
* Update dependencies from https://github.com/dotnet/runtime build 20201009.6 (#26755) [release/5.0] Update dependencies from dotnet/runtime * Update dependencies from https://github.com/dotnet/efcore build 20201009.3 (#26764) [release/5.0] Update dependencies from dotnet/efcore * Add docs for Session, Diagnostics.EntityFrameworkCore, MiddlewareAnalysis and HeaderPropagation (#26720) * Update dependencies from https://github.com/dotnet/runtime build 20201010.7 (#26792) [release/5.0] Update dependencies from dotnet/runtime * !!! Correct condition controlling `public` API analysis !!! (#26797) * !!! Correct condition controlling `public` API analysis !!! - #26785 demonstrated analyzers were inoperable * Remove unused `public` API files * Update `public` API files - three Components files were missing `#nullable enable` - `nullable` annotations missing or out-of-date elsewhere * Ignore `public` API files completely during source build - do not warn about unused files * Update more `public` API files * Update dependencies from https://github.com/dotnet/efcore build 20201012.2 (#26816) Microsoft.EntityFrameworkCore.Tools , dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.Design , Microsoft.EntityFrameworkCore.InMemory , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.SqlServer From Version 5.0.0-rtm.20509.3 -> To Version 5.0.0 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Quarantine flaky test (#26627) * Stabilize package Versions for 5.0.0 (#26650) - remove `$(DisableServicingFeatures)` property; `$(IsServicingBuild)` works now * Remove unneeded package sources * Fix PublicAPI.Unshipped.txt files to match source * Fix PublicAPI.Unshipped.txt files to match source II * Add <inheritdoc /> Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Stephen Halter <[email protected]> Co-authored-by: Doug Bunting <[email protected]> Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Pranav K <[email protected]> Co-authored-by: Tanay Parikh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
publicmembers #26785 demonstrated analyzers were inoperable