Move to stable Microsoft.CodeAnalysis.PublicApiAnalyzers version #25662
Conversation
ghost
added
the
area-infrastructure
| <ItemGroup Condition=" '$(IsImplementationProject)' == 'true' AND | ||
|
|
||
| <ItemGroup Condition=" Exists('$(MSBuildProjectDirectory)\PublicAPI.*.txt') AND | ||
| '$(IsImplementationProject)' == 'true' AND |
There was a problem hiding this comment.
New version emits errors if Public API baseline files are missing
There was a problem hiding this comment.
Nice - would be good to revert this once we can fix all the occurrences.
There was a problem hiding this comment.
Agree. If we undid this change and eliminated analyzers and msbuild tasks, we'd know for sure the public API is covered. Might need to invent a special ImNotPubliclyConsumable flag for Microsoft.Web.Xdt.Extensions and other special cases😺
First, we need to be able to analyze projects containing *.cshtml or *.razor files:
- Microsoft.AspNetCore.Authentication.AzureAD.UI
- Microsoft.AspNetCore.Authentication.AzureADB2C.UI
- Microsoft.AspNetCore.Components.Authorization
- Microsoft.AspNetCore.Identity.UI
Do we have an issue tracking this problem❔ /cc @sharwell @mavasani
There was a problem hiding this comment.
dotnet/roslyn#47350 is tracking it, but it might need to be fixed in aspnetcore.
| <AdditionalFiles Include="PublicAPI.Shipped.txt" | ||
| Condition=" Exists('$(MSBuildProjectDirectory)\$(_TFMDirectory)\PublicAPI.Shipped.txt') " /> | ||
| <AdditionalFiles Include="PublicAPI.Unshipped.txt" | ||
| Condition=" Exists('$(MSBuildProjectDirectory)\$(_TFMDirectory)\PublicAPI.Unshipped.txt') " /> |
There was a problem hiding this comment.
Done in the .targets file for the package now
| !('$(IsImplementationProject)' == 'true' AND | ||
| '$(DotNetBuildFromSource)' != 'true' AND | ||
| ! $(RepoRelativeProjectDir.Contains('Tools'))) "> | ||
| <Warning Text="Public API baseline files ignored." /> |
| <ItemGroup Condition=" '$(IsImplementationProject)' == 'true' AND | ||
|
|
||
| <ItemGroup Condition=" Exists('$(MSBuildProjectDirectory)\PublicAPI.*.txt') AND | ||
| '$(IsImplementationProject)' == 'true' AND |
There was a problem hiding this comment.
Nice - would be good to revert this once we can fix all the occurrences.
No description provided.