Skip to content

Investigate flaky blazor templates #26389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 19 commits into from
Closed

Investigate flaky blazor templates #26389

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
b12a313
Checkpoint
HaoK Sep 28, 2020
d1205fc
Checkpoint
HaoK Sep 28, 2020
eb1df39
Why no run?
HaoK Sep 28, 2020
e224b4b
Turn on bin log for templates test
HaoK Sep 29, 2020
ea39f9f
Reenable tests
HaoK Oct 5, 2020
186bb09
Update BlazorTemplates.Tests.csproj
HaoK Oct 5, 2020
d5ca02b
Update ci.yml
HaoK Oct 5, 2020
6a71249
Update ci.yml
HaoK Oct 5, 2020
eab9bd0
Update BlazorWasmTemplateTest.cs
HaoK Oct 5, 2020
346e06e
Update BlazorServerTemplateTest.cs
HaoK Oct 5, 2020
bd2fd72
Update BlazorWasmTemplateTest.cs
HaoK Oct 5, 2020
10e6da0
Try swallow webdriver exceptions for storage cleanup
HaoK Oct 14, 2020
b89b9d2
Try cleaning up certs
HaoK Oct 14, 2020
e598da6
Update AspNetProcess.cs
HaoK Oct 14, 2020
10d32f6
Update BlazorWasmTemplateTest.cs
HaoK Oct 14, 2020
7b68a26
Update AspNetProcess.cs
HaoK Oct 14, 2020
d0862b4
Try disabling parallelization
HaoK Oct 14, 2020
c88be7a
Merge branch 'master' into haok/wasmtemp
HaoK Oct 15, 2020
bb4a224
Update AssemblyInfo.AssemblyFixtures.cs
HaoK Oct 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/ProjectTemplates/BlazorTemplates.Tests/AssemblyInfo.AssemblyFixtures.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
using Microsoft.AspNetCore.E2ETesting;
using Microsoft.AspNetCore.Testing;
using Templates.Test.Helpers;
using Xunit;

[assembly: AssemblyFixture(typeof(ProjectFactoryFixture))]
[assembly: AssemblyFixture(typeof(SeleniumStandaloneServer))]

[assembly: CollectionBehavior(DisableTestParallelization = true)]
1 change: 0 additions & 1 deletion src/ProjectTemplates/BlazorTemplates.Tests/BlazorServerTemplateTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,6 @@ private void TestBasicNavigation()
}

[Theory]
[QuarantinedTest]
[InlineData("IndividualB2C", null)]
[InlineData("IndividualB2C", new string[] { "--called-api-url \"https://graph.microsoft.com\"", "--called-api-scopes user.readwrite" })]
[InlineData("SingleOrg", null)]
Expand Down
3 changes: 0 additions & 3 deletions src/ProjectTemplates/BlazorTemplates.Tests/BlazorWasmTemplateTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,6 @@ private void ValidateAppWorksOffline(Project project, string listeningUri, bool
}

[ConditionalFact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/23992")]
// LocalDB doesn't work on non Windows platforms
[OSSkipCondition(OperatingSystems.Linux | OperatingSystems.MacOSX)]
public Task BlazorWasmHostedTemplate_IndividualAuth_Works_WithLocalDB()
Expand All @@ -271,7 +270,6 @@ public Task BlazorWasmHostedTemplate_IndividualAuth_Works_WithLocalDB()
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/23992")]
public Task BlazorWasmHostedTemplate_IndividualAuth_Works_WithOutLocalDB()
{
return BlazorWasmHostedTemplate_IndividualAuth_Works(false);
Expand Down Expand Up @@ -346,7 +344,6 @@ private async Task BlazorWasmHostedTemplate_IndividualAuth_Works(bool useLocalDb
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/23639")]
public async Task BlazorWasmStandaloneTemplate_IndividualAuth_Works()
{
// Additional arguments are needed. See: https://github.com/dotnet/aspnetcore/issues/24278
Expand Down
2 changes: 2 additions & 0 deletions src/ProjectTemplates/Shared/AspNetProcess.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
using System.Threading.Tasks;
using AngleSharp.Dom.Html;
using AngleSharp.Parser.Html;
using Microsoft.AspNetCore.Certificates.Generation;
using Microsoft.AspNetCore.Internal;
using Microsoft.AspNetCore.Server.IntegrationTesting;
using Microsoft.Extensions.CommandLineUtils;
Expand Down Expand Up @@ -45,6 +46,7 @@ public AspNetProcess(
bool usePublishedAppHost = false,
ILogger logger = null)
{
CertificateManager.Instance.CleanupHttpsCertificates();
_developmentCertificate = DevelopmentCertificate.Create(workingDirectory);

_output = output;
Expand Down