Fix gRPC interop tests #24824
Merged
Fix gRPC interop tests #24824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JunTaoLuo Were these tests just broken, or disabled? Are additional changes required for these tests to run again? |
|
The tests were disabled because they were failing on Helix after an SDK change, #24182. I forgot to ping you on it sorry. |
|
You need to revert the changes aspnetcore/src/Grpc/test/InteropTests/InteropTests.csproj Lines 7 to 8 in dafe866 |
JunTaoLuo
reviewed
Aug 12, 2020
| @@ -4,8 +4,7 @@ | |||
| <ContainsFunctionalTestAssets>true</ContainsFunctionalTestAssets> | |||
| <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> | |||
|
|
|||
| <!-- https://github.com/dotnet/aspnetcore/issues/24182 --> | |||
| <BuildHelixPayload>false</BuildHelixPayload> | |||
| <BuildHelixPayload>true</BuildHelixPayload> | |||
There was a problem hiding this comment.
You can just remove it, it's default to true.
JunTaoLuo
approved these changes
Aug 12, 2020
JamesNK
force-pushed
the
jamesnk/grpc-reenableinteroptests
branch
from
7870b94 to
25d6851
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24182