Skip to content

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Aug 12, 2020

Fixes #24182

@JamesNK JamesNK requested a review from JunTaoLuo August 12, 2020 02:47
@JamesNK
Copy link
Member Author

JamesNK commented Aug 12, 2020

@JunTaoLuo Were these tests just broken, or disabled? Are additional changes required for these tests to run again?

@JunTaoLuo
Copy link
Contributor

The tests were disabled because they were failing on Helix after an SDK change, #24182. I forgot to ping you on it sorry.

@JunTaoLuo
Copy link
Contributor

You need to revert the changes

<!-- https://github.com/dotnet/aspnetcore/issues/24182 -->
<BuildHelixPayload>false</BuildHelixPayload>
to re-enable running the tests.

@Pilchie Pilchie added the area-grpc Includes: GRPC wire-up, templates label Aug 12, 2020
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can just remove it, it's default to true.

@JamesNK JamesNK force-pushed the jamesnk/grpc-reenableinteroptests branch from 7870b94 to 25d6851 Compare August 13, 2020 01:43
@JamesNK JamesNK merged commit 82324bf into master Aug 13, 2020
@JamesNK JamesNK deleted the jamesnk/grpc-reenableinteroptests branch August 13, 2020 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-grpc Includes: GRPC wire-up, templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grpc Interop tests assembly load failure on Helix
3 participants