Skip to content

Grpc Interop tests assembly load failure on Helix #24182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JunTaoLuo opened this issue Jul 22, 2020 · 2 comments · Fixed by #24824
Closed

Grpc Interop tests assembly load failure on Helix #24182

JunTaoLuo opened this issue Jul 22, 2020 · 2 comments · Fixed by #24824
Assignees
Labels
area-grpc Includes: GRPC wire-up, templates
Milestone

Comments

@JunTaoLuo
Copy link
Contributor

JunTaoLuo commented Jul 22, 2020

The gRPC interop tests are currently disabled.

We saw failures after the latest dependency updates brought breaking Logging changes in the runtime: https://dev.azure.com/dnceng/public/_build/results?buildId=739743&view=results

The error suggests that the wrong version of the M.E.Logging.Console is being loaded at runtime:

[ERROR] Unhandled exception. System.TypeLoadException: Could not load type 'Microsoft.Extensions.Logging.Console.SimpleConsoleFormatterOptions' from assembly 'Microsoft.Extensions.Logging.Console, Version=5.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60'.
[ERROR]    at InteropTestsWebsite.Program.<>c.<CreateHostBuilder>b__1_0(ILoggingBuilder builder)
[ERROR]    at Microsoft.Extensions.Hosting.HostingHostBuilderExtensions.<>c__DisplayClass5_0.<ConfigureLogging>b__1(ILoggingBuilder builder)
[ERROR]    at Microsoft.Extensions.DependencyInjection.LoggingServiceCollectionExtensions.AddLogging(IServiceCollection services, Action`1 configure)
[ERROR]    at Microsoft.Extensions.Hosting.HostingHostBuilderExtensions.<>c__DisplayClass5_0.<ConfigureLogging>b__0(HostBuilderContext context, IServiceCollection collection)
[ERROR]    at Microsoft.Extensions.Hosting.HostBuilder.CreateServiceProvider()
[ERROR]    at Microsoft.Extensions.Hosting.HostBuilder.Build()
[ERROR]    at InteropTestsWebsite.Program.Main(String[] args) in F:\workspace\_work\1\s\src\Grpc\test\testassets\InteropWebsite\Program.cs:line 33
Writing minidump to file /home/helixbot/dotnetbuild/dumps/dotnet.31827.dmp
Written 93696000 bytes (22875 pages) to core file
Dump successfully written

I suspect that the helix environment didn't install the correct aspnetcore runtime and therefore the M.E.Logging.Console binary that was loaded is old.

@JunTaoLuo JunTaoLuo added the area-grpc Includes: GRPC wire-up, templates label Jul 22, 2020
@JunTaoLuo JunTaoLuo added this to the Next sprint planning milestone Jul 22, 2020
@ghost
Copy link

ghost commented Jul 22, 2020

Thanks for contacting us.
We're moving this issue to the Next sprint planning milestone for future evaluation / consideration. We will evaluate the request when we are planning the work for the next milestone. To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@dougbu
Copy link
Contributor

dougbu commented Jul 26, 2020

Could this be related to the ...AddConsole(...) -> ...AddSimpleConsole(...) changes made in #23978, specifically files src/Grpc/test/testassets/InteropClient/InteropClient.cs and src/Grpc/test/testassets/InteropClient/InteropClient.cs❔ That was done prior to disabling these tests.

@JamesNK JamesNK assigned JamesNK and unassigned JunTaoLuo Aug 12, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Sep 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-grpc Includes: GRPC wire-up, templates
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants