[master] Update dependencies from dotnet/efcore dotnet/arcade dotnet/runtime dotnet/roslyn #23978
Conversation
![dotnet-maestro[bot]](https://avatars.githubusercontent.com/in/16706?s=60&v=4){kind=small}
…714.3 Microsoft.DotNet.GenAPI , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.Arcade.Sdk From Version 5.0.0-beta.20330.3 -> To Version 5.0.0-beta.20364.3
ghost
added
area-infrastructure
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
…715.11 Microsoft.EntityFrameworkCore.Tools , Microsoft.EntityFrameworkCore.SqlServer , dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.InMemory From Version 5.0.0-preview.8.20365.2 -> To Version 5.0.0-rc.1.20365.11
dotnet-maestro
bot
changed the title
…715.12 Microsoft.EntityFrameworkCore.Tools , Microsoft.EntityFrameworkCore.SqlServer , dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.InMemory From Version 5.0.0-preview.8.20365.2 -> To Version 5.0.0-rc.1.20365.12
…715.14 Microsoft.EntityFrameworkCore.Tools , Microsoft.EntityFrameworkCore.SqlServer , dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.InMemory From Version 5.0.0-preview.8.20365.2 -> To Version 5.0.0-rc.1.20365.14
…715.16 Microsoft.EntityFrameworkCore.Tools , Microsoft.EntityFrameworkCore.SqlServer , dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.InMemory From Version 5.0.0-preview.8.20365.2 -> To Version 5.0.0-rc.1.20365.16
…716.1 Microsoft.EntityFrameworkCore.Tools , Microsoft.EntityFrameworkCore.SqlServer , dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.InMemory From Version 5.0.0-preview.8.20365.2 -> To Version 5.0.0-rc.1.20366.1
|
We seem to be in race between dotnet/efcore publications to the BAR and completion of our validation build. @mmitche if we were to make the dotnet/efcore subscription un-batchable, would we be able to get this in w/o another update from the bot❔ |
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
|
The one test failing is, |
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
This is failing consistently in this update. It is failing locally as well. @jkotalik, do you have the context to take a look at this? |
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
|
I don't have context on DotNetMuxerTests. Not sure who would though... |
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
…0716.14 System.Diagnostics.DiagnosticSource , System.Diagnostics.EventLog , System.Drawing.Common , System.IO.Pipelines , System.ComponentModel.Annotations , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Options , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Primitives , Microsoft.Extensions.Logging , Microsoft.Extensions.Internal.Transport , Microsoft.Extensions.Hosting.Abstractions , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.Configuration.Xml , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.Hosting , Microsoft.Extensions.Http , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry , Microsoft.Win32.SystemEvents , Microsoft.NETCore.App.Internal , Microsoft.NETCore.App.Ref , System.Net.Http.Json , System.Windows.Extensions , System.Threading.Channels , System.Net.Http.WinHttpHandler , System.Net.WebSockets.WebSocketProtocol , System.Reflection.Metadata , System.Resources.Extensions , System.Runtime.CompilerServices.Unsafe , System.Security.Cryptography.Cng , System.Security.Cryptography.Pkcs , System.Security.Cryptography.Xml , System.Security.Permissions , System.Security.Principal.Windows , System.ServiceProcess.ServiceController , System.Text.Encodings.Web , System.Text.Json From Version 5.0.0-preview.8.20361.2 -> To Version 5.0.0-rc.1.20366.14
dotnet-maestro
bot
changed the title
…717.2 Microsoft.EntityFrameworkCore.Tools , Microsoft.EntityFrameworkCore.SqlServer , dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.InMemory From Version 5.0.0-preview.8.20365.2 -> To Version 5.0.0-rc.1.20367.2
dotnet-maestro
bot
changed the title
@BrennanConroy, can you please take a look? Hopefully this is a quick fix. |
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
…0720.4 System.Diagnostics.DiagnosticSource , System.Diagnostics.EventLog , System.Drawing.Common , System.IO.Pipelines , System.ComponentModel.Annotations , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Options , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Primitives , Microsoft.Extensions.Logging , Microsoft.Extensions.Internal.Transport , Microsoft.Extensions.Hosting.Abstractions , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.Configuration.Xml , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.Hosting , Microsoft.Extensions.Http , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry , Microsoft.Win32.SystemEvents , Microsoft.NETCore.App.Internal , Microsoft.NETCore.App.Ref , System.Net.Http.Json , System.Windows.Extensions , System.Threading.Channels , System.Net.Http.WinHttpHandler , System.Net.WebSockets.WebSocketProtocol , System.Reflection.Metadata , System.Resources.Extensions , System.Runtime.CompilerServices.Unsafe , System.Security.Cryptography.Cng , System.Security.Cryptography.Pkcs , System.Security.Cryptography.Xml , System.Security.Permissions , System.Security.Principal.Windows , System.ServiceProcess.ServiceController , System.Text.Encodings.Web , System.Text.Json From Version 5.0.0-preview.8.20361.2 -> To Version 5.0.0-rc.1.20370.4
dotnet-maestro
bot
changed the title
…717.11 Microsoft.Net.Compilers.Toolset From Version 3.8.0-1.20361.1 -> To Version 3.8.0-1.20367.11
dotnet-maestro
bot
changed the title
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
dotnet-maestro
bot
requested review from
SteveSandersonMS and
a team
as code owners
|
@JamesNK \ @JunTaoLuo could you look at the failing GRPC tests? |
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
|
@pranavkm I took a quick look and it appears the tests are timing out while waiting for the server to report it is ready. Timeout here: Waiting for app to write to console that it is ready: aspnetcore/src/Grpc/test/InteropTests/Helpers/WebsiteProcess.cs Lines 78 to 81 in d7bcde5 Has something changed to no longer write that text to the console? |
|
@BrennanConroy mentioned that it could be logging changes: Essentially the grpc libraries are using incompatible versions of M.E.Logging. Let me see if I can do something about it. I suspect I can resolve the version conflicts. |
There were changes to the console logger in this dependency update, maybe output is subtly different? |
| @@ -37,7 +37,7 @@ public static void Main(string[] args) | |||
| Host.CreateDefaultBuilder(args) | |||
| .ConfigureLogging(builder => | |||
| { | |||
| builder.AddConsole(o => o.DisableColors = true); | |||
| builder.AddSimpleConsole(o => o.DisableColors = true); | |||
There was a problem hiding this comment.
This change is probably why the gRPC interop tests failing. The tests are expecting a certain message logged to the console.
There was a problem hiding this comment.
The functionality should not have changed. I'm comparing the outputs.
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
|
aspnetcore/src/Grpc/test/InteropTests/Helpers/WebsiteProcess.cs Lines 78 to 81 in d7bcde5
The server is explicitly writing "Application started." out to the console. That will work even if logging is turned off. aspnetcore/src/Grpc/test/testassets/InteropWebsite/Startup.cs Lines 39 to 40 in d7bcde5 However, still figure out why logging is no longer working. |
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
| @@ -107,6 +107,7 @@ public override int EndRead(IAsyncResult asyncResult) | |||
| public override void EndWrite(IAsyncResult asyncResult) | |||
| => _inner.EndWrite(asyncResult); | |||
|
|
|||
| [Obsolete("This Remoting API is not supported and throws PlatformNotSupportedException.", DiagnosticId = "SYSLIB0010", UrlFormat = "https://aka.ms/dotnet-warnings/{0}")] | |||
There was a problem hiding this comment.
Why is [Obsolete(...)] appropriate here❔ Unless it works in some scenarios, keeping the method around doesn't accomplish anything except give those who rebuild a warning things will break when they run. We usually only [Obsolete] things that still work.
There was a problem hiding this comment.
The error message that accompanied this obsoletion mentioned to mark overrides as obsolete. Also: #23978
There was a problem hiding this comment.
That makes sense if the [Obsolete] base works. I'm not understanding why the override exists any longer. Same question for https://github.com/dotnet/aspnetcore/pull/23978/files#diff-27ac84ac193b5e4debda40d50bfd8d52R110
Where were you linking other than back to this PR❔
There was a problem hiding this comment.
It was a comment by @ericstj explaining what was needed here.
There was a problem hiding this comment.
This stream is wrapping a stream and providing different behavior than base. If you removed the override it would be a behavior change.
There was a problem hiding this comment.
Suggest the comment should be reworded then. It flat-out states the API doesn't work while, from what you say @ericstj, everything will be fine i.e. this comment applies only to the overridden base.
There was a problem hiding this comment.
I'm talking about your API. Base stream will still throw which is most likely what will happen, but passed in stream may override this and you should preserve calling that. I don't think its important to customize the message.
|
I can't seem to repro the helix failure locally so I suspect there's some issue with the helix payload. I'm disabling the interop test for now to unblock ingestion. Issue tracking the tests is at #24182 |
Auto-Merge StatusThis pull request will be merged because the following merge policies have succeeded.
|
dotnet-maestro
bot
deleted the
darc-master-96857ce5-49cd-4893-b9d1-338816840879
branch
This pull request updates the following dependencies
From https://github.com/dotnet/arcade
From https://github.com/dotnet/efcore
From https://github.com/dotnet/runtime
From https://github.com/dotnet/roslyn