Migrating sources from dotnet/extensions #19033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
\n\nCommit migrated from dotnet/extensions@9c392a9
\n\nCommit migrated from dotnet/extensions@204a4ee
\n\nCommit migrated from dotnet/extensions@b791bce
\n\nCommit migrated from dotnet/extensions@2dd5bf8
…ge/release/3.0-to-master [automated] Merge branch 'release/3.0' => 'master'\n\nCommit migrated from dotnet/extensions@969f9a1
- brings in new Arcade bits\n\nCommit migrated from dotnet/extensions@7005708
…ge/release/3.0-to-master [automated] Merge branch 'release/3.0' => 'master'\n\nCommit migrated from dotnet/extensions@f8d29bc
…otnet/extensions#2210) - unblocks work on aspnet/AspNetCoredotnet/extensions#4923 - arguments for inside and outside men of service reference doc gen tool are mixed by default - users may add either argument type to the end of the outside man's command line - e.g. "command --unexpected unexpectedValue --expected" can now set the "expected" option - only "--unexpected" and "unexpectedValue" are added to RemainingArguments in that case - default behaviour of the command-line parser is unchanged to avoid breaking existing applications - new switch is supported only when calling `CommandLineApplication` constructor for top-level commands - `dotnet-getdocument` (the outside man) has no (sub)commands and expanding scope would increase churn nits: take VS suggestions in changed files\n\nCommit migrated from dotnet/extensions@e443397
…/3.0\n\nCommit migrated from dotnet/extensions@5c41636
…ge/release/3.0-to-master [automated] Merge branch 'release/3.0' => 'master'\n\nCommit migrated from dotnet/extensions@14efea2
…ge/release/3.0-preview9-to-release/3.0 [automated] Merge branch 'release/3.0-preview9' => 'release/3.0'\n\nCommit migrated from dotnet/extensions@a459d9e
…ge/release/3.0-to-master [automated] Merge branch 'release/3.0' => 'master'\n\nCommit migrated from dotnet/extensions@a070a81
- no-op merge, no reason to wait\n\nCommit migrated from dotnet/extensions@7f64f14
…/3.0\n\nCommit migrated from dotnet/extensions@07c506d
…ns#2226) - no-op merge\n\nCommit migrated from dotnet/extensions@44f2dd8
- no-op merge\n\nCommit migrated from dotnet/extensions@8f37920
- no-op merge\n\nCommit migrated from dotnet/extensions@39d5064
- brings newer Arcade\n\nCommit migrated from dotnet/extensions@4afab35
…ge/release/3.0-to-master [automated] Merge branch 'release/3.0' => 'master'\n\nCommit migrated from dotnet/extensions@12a28e4
\n\nCommit migrated from dotnet/extensions@033ea04
…ge/release/3.0-to-master [automated] Merge branch 'release/3.0' => 'master'\n\nCommit migrated from dotnet/extensions@d8590b1
\n\nCommit migrated from dotnet/extensions@ae9d51f
dougbu
approved these changes
Feb 20, 2020
| @@ -2,12 +2,13 @@ | |||
|
|
|||
| <PropertyGroup> | |||
| <Description>A simple object pool implementation.</Description> | |||
| <TargetFramework>netstandard2.0</TargetFramework> | |||
| <TargetFrameworks>netstandard2.0;$(DefaultNetCoreTargetFramework)</TargetFrameworks> | |||
JunTaoLuo
added
the
blocked
|
Waiting for #19122 |
- Multi-target ObjectPool - Move Embedded.Manifest.Task.Internal.Entry to the public namespace - Remove ref assemblies from AspNetCore.Testing - Skip TestPathUtilitiesTest since it's a pattern we want to migrate away from - Fix FileProviders.Abstractions version in Embedded.*.nuspec - Add workarounds for project references to FileProviders.Embedded
JunTaoLuo
force-pushed
the
johluo/migrating-extensions
branch
from
b180f84 to
7d1f5d8
Compare
JunTaoLuo
changed the title
added 7 commits
February 20, 2020 14:23
…tcore into johluo/migrating-extensions
|
@javiercn @SteveSandersonMS who can help me take a look at the Blazor Template tests failures? I can't seem to run the tests locally so I can't debug the failure described in the CI test logs. |
|
It turns out there are binlogs captured on the CI, so I might be unblocked. |
|
@JunTaoLuo Please let us know if you still need assistance after checking those logs. Today was the final day before code-complete for the current Blazor milestone, so Javier and I were working pretty furiously on that, hence not responding sooner. Hope that's OK! |
|
Turns out it's an issue with ref packs again. I'll look into a fix. This PR might need some additional verification. |
|
@dotnet/aspnet-build can y'all look at this again before I merge? I'll also try to compare the ref pack outputs to ensure we didn't miss anything. |
|
I verified the ref packs and everything looks good |
JunTaoLuo
removed
the
blocked
wtgodbe
reviewed
Feb 21, 2020
| @@ -94,14 +78,17 @@ and are generated based on the last package release. | |||
| <LatestPackageReference Include="System.Net.Http" Version="$(SystemNetHttpPackageVersion)" /> | |||
| <LatestPackageReference Include="System.Reflection.Metadata" Version="$(SystemReflectionMetadataPackageVersion)" /> | |||
| <LatestPackageReference Include="System.Runtime.CompilerServices.Unsafe" Version="$(SystemRuntimeCompilerServicesUnsafePackageVersion)" /> | |||
| <LatestPackageReference Include="System.Runtime.InteropServices.RuntimeInformation" Version="$(SystemRuntimeInteropServicesRuntimeInformationPackageVersion)" /> | |||
There was a problem hiding this comment.
For my understanding - these were packages that (previously) Extensions depended on, but not this repo? And now we're adding a dependency on them since we're bringing in the Extensions stuff that uses them?
wtgodbe
approved these changes
Feb 21, 2020
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is made on top of #19032 to simplify reviews. When approved, the changes in both PRs will be merged into master.
Update: all build/test issues have been resolved and I have re-targeted the base branch to master, I'll add more details in the PR description but this is ready to be merged.
Components being migrated:
Note that I anticipate that we will need to address a few more issues in collaboration with the dotnet/runtime team. Specifically:
I'll work with @maryamariyan on the dotnet side to address the remaining concerns once there is progress on that side.