Migrating from Extensions #19032
Closed
Migrating from Extensions #19032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- blocking aspnet/AspNetCoredotnet/extensions#1293 dependency update PR - commit 3ec8c35e450c lost `AssemblyName` substitution - tasks assembly in package incorrectly named ".Manifest.Task.dll" \n\nCommit migrated from dotnet/extensions@77403f3
…ge/release/3.0-to-master [automated] Merge branch 'release/3.0' => 'master'\n\nCommit migrated from dotnet/extensions@3f8ee55
* Special case Disposing DotNetObjectReferences This removes a public JSInvokable method required for disposing DotNetObjectReferences \n\nCommit migrated from dotnet/extensions@d6bfc28
* API Review: JSRuntime * Rename JSRuntimeBase -> JSRuntime * Rename JSInProcessRuntimeBase -> JSInProcessRuntime * Rename DotNetObjectRef -> DotNetObjectReference * Update JSRuntime to return ValueTask * Make InvokeAsync APIs that explicitly cancels and API that default cancels more crisp * Introduce void invoking APIs * Fixup method names on DotNetDispatcher \n\nCommit migrated from dotnet/extensions@93d3ae4
\n\nCommit migrated from dotnet/extensions@cfef5e0
* Remove the use of async local JSRuntime * Update DotNetDispatcher to accept a JSRuntime instance rather than use a ambient value. * Modify DotNetObjectReference to start tracking it's value during serialization. \n\nCommit migrated from dotnet/extensions@ae9878b
…et-maestro-bot/Common into merge/release/3.0-to-master \n\nCommit migrated from dotnet/extensions@4357bfd
…ge/release/3.0-to-master [automated] Merge branch 'release/3.0' => 'master'\n\nCommit migrated from dotnet/extensions@65707ff
…2190) \n\nCommit migrated from dotnet/extensions@72bcb43
\n\nCommit migrated from dotnet/extensions@9c392a9
\n\nCommit migrated from dotnet/extensions@204a4ee
\n\nCommit migrated from dotnet/extensions@b791bce
\n\nCommit migrated from dotnet/extensions@2dd5bf8
…ge/release/3.0-to-master [automated] Merge branch 'release/3.0' => 'master'\n\nCommit migrated from dotnet/extensions@969f9a1
- brings in new Arcade bits\n\nCommit migrated from dotnet/extensions@7005708
…ge/release/3.0-to-master [automated] Merge branch 'release/3.0' => 'master'\n\nCommit migrated from dotnet/extensions@f8d29bc
…otnet/extensions#2210) - unblocks work on aspnet/AspNetCoredotnet/extensions#4923 - arguments for inside and outside men of service reference doc gen tool are mixed by default - users may add either argument type to the end of the outside man's command line - e.g. "command --unexpected unexpectedValue --expected" can now set the "expected" option - only "--unexpected" and "unexpectedValue" are added to RemainingArguments in that case - default behaviour of the command-line parser is unchanged to avoid breaking existing applications - new switch is supported only when calling `CommandLineApplication` constructor for top-level commands - `dotnet-getdocument` (the outside man) has no (sub)commands and expanding scope would increase churn nits: take VS suggestions in changed files\n\nCommit migrated from dotnet/extensions@e443397
…/3.0\n\nCommit migrated from dotnet/extensions@5c41636
…ge/release/3.0-to-master [automated] Merge branch 'release/3.0' => 'master'\n\nCommit migrated from dotnet/extensions@14efea2
…ge/release/3.0-preview9-to-release/3.0 [automated] Merge branch 'release/3.0-preview9' => 'release/3.0'\n\nCommit migrated from dotnet/extensions@a459d9e
…ge/release/3.0-to-master [automated] Merge branch 'release/3.0' => 'master'\n\nCommit migrated from dotnet/extensions@a070a81
- no-op merge, no reason to wait\n\nCommit migrated from dotnet/extensions@7f64f14
…/3.0\n\nCommit migrated from dotnet/extensions@07c506d
…ns#2226) - no-op merge\n\nCommit migrated from dotnet/extensions@44f2dd8
\n\nCommit migrated from dotnet/extensions@99bba36
…ge/release/3.1-to-master [automated] Merge branch 'release/3.1' => 'master'\n\nCommit migrated from dotnet/extensions@1f26860
- no-op merge\n\nCommit migrated from dotnet/extensions@3e617ba
…ns#2817) \n\nCommit migrated from dotnet/extensions@b624d6b
…et-maestro-bot/Common into dotnet-maestro-bot-merge/release/3.1-to-master \n\nCommit migrated from dotnet/extensions@3873a07
…ge/release/3.1-to-master [automated] Merge branch 'release/3.1' => 'master'\n\nCommit migrated from dotnet/extensions@dea81ef
…ge/release/3.1-to-master [automated] Merge branch 'release/3.1' => 'master'\n\nCommit migrated from dotnet/extensions@1693e05
…ge/release/3.1-to-master [automated] Merge branch 'release/3.1' => 'master'\n\nCommit migrated from dotnet/extensions@1c2bd97
…extensions#2817)" (dotnet/extensions#2882) This reverts commit dotnet/extensions@b624d6b.\n\nCommit migrated from dotnet/extensions@1286a6f
\n\nCommit migrated from dotnet/extensions@6a4a190
\n\nCommit migrated from dotnet/extensions@b4d6308
\n\nCommit migrated from dotnet/extensions@b6e88cc
…ge/release/3.1-to-master [automated] Merge branch 'release/3.1' => 'master'\n\nCommit migrated from dotnet/extensions@302f677
…mments (dotnet/extensions#2904) \n\nCommit migrated from dotnet/extensions@31b8e7c
\n\nCommit migrated from dotnet/extensions@211046f
* Remove Mono.WebAssembly.Interop \n\nCommit migrated from dotnet/extensions@4ac4b19
…sions#2808) \n\nCommit migrated from dotnet/extensions@cca1c7c
JunTaoLuo
added
the
area-infrastructure
dougbu
reviewed
Feb 14, 2020
|
Is the plan to add commits from #19033 into this PR? Would be good to avoid checking in something that can't compile e.g. |
|
No I don't plan on adding those commits into this PR. Instead, once that PR is completed and approved, I'll simply change #19033's base branch to master and merge. This branch is separated to make reviewing more streamlined between moving the files and resolving the infrastructure updates once the files are moved. |
JunTaoLuo
force-pushed
the
johluo/extensions
branch
from
dbd06f2 to
25b41ef
Compare
|
I've retargeted #19033 so there's no need to keep this open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For illustration purposes only. I'll open a separate PR with the necessary modifications on top of this migration to build and test.