Skip to content

Perform symbol publication using Microsoft.SymbolUploader.Build.Task #10358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 24, 2019
Merged

Perform symbol publication using Microsoft.SymbolUploader.Build.Task #10358

merged 2 commits into from
May 24, 2019

Conversation

dougbu
Copy link
Contributor

@dougbu dougbu commented May 17, 2019

  • aspnet/AspNetCore-Internal#2126
  • add new stage template and project that publishes symbols to MSDL and SymWeb

@dougbu dougbu requested a review from a team May 17, 2019 23:17
@dougbu dougbu force-pushed the dougbu/arcade.symbol.task.2126 branch from 566b0fb to 8740add Compare May 17, 2019 23:20
dougbu
dougbu commented May 17, 2019
View reviewed changes
Copy link
Contributor Author

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://dnceng.visualstudio.com/internal/_build/results?buildId=193044 is the build to watch because the new stage won't exist in PR verification.

@Eilon Eilon added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label May 17, 2019
@dougbu
Copy link
Contributor Author

dougbu commented May 18, 2019 •
edited
Loading

@joeloff the official build of the same branch (modulo irrelevant whitespace in the YAML) is still failing the Sign Check step with the same errors as described in #10241. The same thing is happening in all other AspNetCore-ci-official builds, including the one for 'master' after you merged #10340 (see https://dnceng.visualstudio.com/internal/_build/results?buildId=192996&view=logs&j=f31c9f97-4411-58e7-49ac-fc73f645e6b6&t=ef92295d-dfa0-5952-f0c2-498c3b48582b&l=128 and https://dnceng.visualstudio.com/internal/_build/results?buildId=192996&view=logs&j=f31c9f97-4411-58e7-49ac-fc73f645e6b6&t=ef92295d-dfa0-5952-f0c2-498c3b48582b&l=168). Any ideas?

My guess is that using $(TargetDir) for the @(_cabs) item group is incorrect and should be $(SharedFramework.TargetDir). In the build for your commit, the $(TargetDir) is F:\workspace\_work\1\s\artifacts\bin\SharedFrameworkLib\x64\Release\ and $(SharedFramework.TargetDir) is F:\workspace\_work\1\s\artifacts\bin\SharedFramework\x64\Release\en-US\. I'll send a PR and do a trial "official" build to see if I'm right…

dougbu
dougbu commented May 18, 2019
View reviewed changes
@dougbu dougbu force-pushed the dougbu/arcade.symbol.task.2126 branch from 8740add to 3be668e Compare May 18, 2019 05:14
@dougbu
Copy link
Contributor Author

dougbu commented May 18, 2019

@dougbu dougbu force-pushed the dougbu/arcade.symbol.task.2126 branch from 3be668e to e73f8ae Compare May 18, 2019 17:09
@dougbu
Copy link
Contributor Author

dougbu commented May 18, 2019

New trial official build is https://dnceng.visualstudio.com/internal/_build/results?buildId=193490

@dougbu dougbu force-pushed the dougbu/arcade.symbol.task.2126 branch 3 times, most recently from bb4aaad to b126c9e Compare May 20, 2019 05:04
natemcmaster
natemcmaster reviewed May 20, 2019
View reviewed changes
dougbu added 2 commits May 23, 2019 13:27
@dougbu
Perform symbol publication using Microsoft.SymbolUploader.Build.Task
51b6bc1 
- aspnet/AspNetCore-Internal#2126
- add new stage template and project that publishes symbols to MSDL and SymWeb
  - install `dotnet` version matching global.json content
  - restore and build the new project
@dougbu
Address PR comments
502c174 
- expire symbols after 10 years (or so)
- switch from stages to updating our release pipeline
  - revert changes to ci.yml

nits:
- add newlines to logging of published symbols
- add `$env:DOTNET_SKIP_FIRST_TIME_EXPERIENCE` to ci.yml
@dougbu dougbu force-pushed the dougbu/arcade.symbol.task.2126 branch from b126c9e to 502c174 Compare May 23, 2019 20:28
@dougbu
Copy link
Contributor Author

dougbu commented May 23, 2019

🆙📅 to match what's been running fine in https://dnceng.visualstudio.com/internal/_releaseProgress?_a=release-pipeline-progress&releaseId=7988 and many previous iterations of the release pipeline. (Remaining issues are limited to excluding packages that contain assemblies lacking symbols.)

This branch, modulo a rebase and newlines in the symbol packages upload list, also built successfully internally: https://dnceng.visualstudio.com/internal/_build/results?buildId=197523

And, BTW I've addressed your comments @natemcmaster

@dougbu dougbu requested a review from a team May 23, 2019 23:07
@dougbu
Copy link
Contributor Author

dougbu commented May 24, 2019

Another Helix timeout at 4 hours. Most of the tests I looked at timed out though the failures on Debian.8.Amd64.Open were due to System.Security.Cryptography.CryptographicExceptions. In any case, nothing conceivably related to the changes in this PR.

Merging…

@dougbu dougbu merged commit 3bb9cda into master May 24, 2019
@ghost ghost deleted the dougbu/arcade.symbol.task.2126 branch May 24, 2019 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natemcmaster natemcmaster natemcmaster approved these changes

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dougbu @natemcmaster @Eilon