CopyCabs #10340
Merged
CopyCabs #10340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should copy CAB files if there are any @natemcmaster, I'm assuming that signing is done by the time we hit this target. |
|
@JunTaoLuo and @natemcmaster I believe this is just FYI for you two. @joeloff, yes, the cabs are signed before the copy you're changing. |
JunTaoLuo
approved these changes
May 17, 2019
|
@joeloff the required checks are done. Let's get this in. Unless, that is, you're waiting for something specific in the Helix tests? |
ghost
deleted the
dougbu
added a commit
that referenced
this pull request
May 18, 2019
- most likely cause of failing official builds - small typo in #10340
Merged
dougbu
added a commit
that referenced
this pull request
May 18, 2019
- most likely cause of failing official builds - small typo in #10340: need to find .cab files _below_ `$(TargetDir)`
dougbu
added a commit
that referenced
this pull request
May 18, 2019
- most likely cause of failing official builds - small typo in #10340: need to find .cab files _below_ `$(TargetDir)`
dougbu
added a commit
that referenced
this pull request
May 19, 2019
- most likely cause of failing official builds - small typo in #10340: need to find .cab files _below_ `$(TargetDir)`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy CAB files to artifacts