Skip to content

Fix sign check #10361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 19, 2019
Merged

Fix sign check #10361

merged 1 commit into from
May 19, 2019

Conversation

dougbu
Copy link
Contributor

@dougbu dougbu commented May 18, 2019

@dougbu dougbu requested review from joeloff and a team May 18, 2019 02:39
@dougbu
Copy link
Contributor Author

dougbu commented May 18, 2019

https://dnceng.visualstudio.com/internal/_build/results?buildId=193171 is the official build to watch. Sign checks aren't done in PR validation.

@dougbu dougbu force-pushed the dougbu/fix.sign.check branch from 7fd7e41 to c9844e4 Compare May 18, 2019 05:14
@dougbu
Copy link
Contributor Author

dougbu commented May 18, 2019

New trial official build is https://dnceng.visualstudio.com/internal/_build/results?buildId=193228

@dougbu dougbu added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label May 18, 2019
@dougbu
Fix sign check
8de9c05 
- most likely cause of failing official builds
- small typo in #10340: need to find .cab files _below_ `$(TargetDir)`
@dougbu dougbu force-pushed the dougbu/fix.sign.check branch from c9844e4 to 8de9c05 Compare May 18, 2019 17:10
@dougbu
Copy link
Contributor Author

dougbu commented May 18, 2019

New trial official build is https://dnceng.visualstudio.com/internal/_build/results?buildId=193489

@dougbu
Copy link
Contributor Author

dougbu commented May 19, 2019

https://dnceng.visualstudio.com/internal/_build/results?buildId=193489 was successful and Helix tests timed out due to a general delay in starting Windows jobs. Merging…

@dougbu dougbu merged commit 5502c20 into master May 19, 2019
@dougbu dougbu deleted the dougbu/fix.sign.check branch May 19, 2019 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeloff joeloff joeloff approved these changes

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dougbu @joeloff