[AOT] Clean up AOT warnings in the SPA Proxy project

[amcasey]

Is there an existing issue for this?

• I have searched the existing issues

Is your feature request related to a problem? Please describe the problem.

Split out from #45473 - #45604 suppressed AOT checking of the SPA Proxy project:

aspnetcore/src/Middleware/Spa/SpaProxy/src/Microsoft.AspNetCore.SpaProxy.csproj

Line 7 in f766c4a

<EnableAOTAnalyzer>false</EnableAOTAnalyzer>

Describe the solution you'd like

Enable AOT checking and address all warnings.

Additional context

No response

[javiercn]

@amcasey I'm not sure we need to do anything since this is a dev-only feature.

Spa proxy is a development only feature that is not used during deployment/aot. So, I do not think we need to do anything here? If there is a way we can configure this project to trim the reference as part of the app publishing, that would work great.

[mkArtakMSFT]

Closing based on @javiercn 's comment above as it seems there is no real value due to these warnings are specific only to dev-time enabled feature.

[amcasey]

@mkArtakMSFT I had a quick call with @javiercn about this and it sounded like there was still a bit of work. I haven't checked it out yet, but it sounds like maybe this project is unnecessarily included as a runtime dependency and prevents some trimming that would otherwise happen. Or possibly he just wanted to confirm that that wasn't the case.

[ghost]

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

[amcasey]

Okay, some notes from poking around:

• The user's code does not declare a dependency on Microsoft.AspNetCore.SpaProxy - it's pulled in using ASPNETCORE_HOSTINGSTARTUPASSEMBLIES
• The IHostingStartup for the proxy does nothing unless spa.proxy.json is present
• spa.proxy.json is not published

So, (1) the SPA proxy won't be used by the published app and (2) it's not referenced in a way that should affect trimming.

As a hygiene improvement, we could refrain from publishing the DLL but, AFAICT, that would actually require deleting it after publishing (since there's no built-in facility for controlling the publication of nuget references) and putting that code in the template seems kind of ugly.

[amcasey]

If @javiercn agrees, I think we can just close this.

[amcasey]

Neat: https://github.com/dotnet/sdk/blob/77cb43cab0a8d7ce648c9ce3d9f191b2411a00ac/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.Shared.targets#L58