Skip to content

Mark SPA Proxy as not for publication in SPA templates #46406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 2, 2023

Conversation

amcasey
Copy link
Member

@amcasey amcasey commented Feb 2, 2023

Mark SPA Proxy as not for publication in SPA templates

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Summary of the changes (Less than 80 chars)

Mark SPA Proxy as not for publication in the SPA templates

Description

The SPA Proxy is only useful at development time, not in production, so it should be included in the output folder, but should not be published.

Fixes #46036

@amcasey amcasey requested review from a team, dougbu and wtgodbe as code owners February 2, 2023 01:21
Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like the correct change but I'm not sure it'll work w/o checking the fix into dotnet/spa-templates then (separately) updating the submodule to use that new commit. My best guess is committing this change will not change what's visible in the other repo and that's not good.

@wtgodbe
Copy link
Member

wtgodbe commented Feb 2, 2023

He did that here: dotnet/spa-templates#117. As long as this commit is updating the submodule commit to use that one (I can't tell via the github UI), we're good

@amcasey
Copy link
Member Author

amcasey commented Feb 2, 2023

This looks like the correct change but I'm not sure it'll work w/o checking the fix into dotnet/spa-templates then (separately) updating the submodule to use that new commit. My best guess is committing this change will not change what's visible in the other repo and that's not good.

The GH UI is displaying things confusingly, but this change is (as @wtgodbe mentioned) just a submodule update to pull in dotnet/spa-templates#117.

@amcasey amcasey merged commit fbdf6ab into dotnet:main Feb 2, 2023
@amcasey amcasey deleted the Gh46036 branch February 2, 2023 17:23
@ghost ghost added this to the 8.0-preview2 milestone Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AOT] Clean up AOT warnings in the SPA Proxy project
3 participants