[Xamarin.Android.Build.Tasks] Fix Aapt2 warnings showing as errors #2027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes (again) dotnet#1770 On windows we are hitting the same issue where the warnings `aapt2` is producing are being logged as errors. The weird part is that the "file" group was not being populated with the right informaton.. This turns out to be down to how `aapt2` is reporting the warnings.. W/ResourceType(23681): For resource 0x0101053d, entry index(1341) is beyond type entryCount(733) W/ResourceType( 5536): For resource 0x0101053d, entry index(1341) is beyond type entryCount(1155) ^ Hmmmmm. This space throws off our regex and results in the entire line ending up in the `message` property. So the fix is to update the regex to allow spaces for the `line` capture group. We then also need to Trim that value before passing it into `int.Parse` to ensure we don't get an error.
jonathanpeppers
approved these changes
Aug 2, 2018
jonpryor
pushed a commit
that referenced
this pull request
Aug 3, 2018
…2027) Fixes (again): #1770 On Windows we are hitting the same issue where the warnings `aapt2` is producing are being logged as errors. The weird part is that the "file" group was not being populated with the right information. This turns out to be down to how `aapt2` is reporting the warnings: there may be *spaces* within the line number portion: W/ResourceType(23681): For resource 0x0101053d, entry index(1341) is beyond type entryCount(733) W/ResourceType( 5536): For resource 0x0101053d, entry index(1341) is beyond type entryCount(1155) ^ This space throws off our regex and results in the entire line ending up in the `message` property. The fix is to update the regex to allow spaces for the `line` capture group. We then also need to Trim that value before passing it into `int.Parse()` to ensure we don't get an error.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes (again) #1770
On windows we are hitting the same issue where the warnings
aapt2is producing are being logged as errors.The weird part is that the "file" group was not being populated
with the right informaton.. This turns out to be down to how
aapt2is reporting the warnings..This space throws off our regex and results in the entire line
ending up in the
messageproperty.So the fix is to update the regex to allow spaces for the
linecapture group. We then also need to Trim that value before passing
it into
int.Parseto ensure we don't get an error.