[Aapt2] Certain warnings now surfaced by aapt2 are being treated as errors

[pjcollins]

Steps to Reproduce

1. msbuild /t:SignAndroidPackage /p:AndroidUseAapt2=true monodroid-samples\Button\DroidButton.csproj /v:diag

https://github.com/xamarin/monodroid-samples/tree/master/Button

I can reproduce this with the default TargetFrameworkVersion of the project (v2.3), as well as v4.0.4, and v4.4. However, if I target v5.0 or greater then my build succeeds.

Expected Behavior

Project builds successfully with Aapt2 enabled.

Actual Behavior

Executing link --manifest C:\Users\peter\AppData\Local\Temp\wtsbowgt.p03\manifest\AndroidManifest.xml --java C:\Users\peter\AppData\Local\Temp\wtsbowgt.p03 --custom-package mono.samples.button -R obj\\Debug\\compiled.flata --auto-add-overlay -I "C:\Program Files (x86)\Android\android-sdk\platforms\android-10\android.jar" --output-text-symbols obj\\Debug\R.txt -o C:\Users\peter\AppData\Local\Temp\wtsbowgt.p03\resources.apk (TaskId:97)
W/ResourceType(23681): error APT0000: For resource 0x0101053d, entry index(1341) is beyond type entryCount(733) [C:\Users\peter\source\monodroid-samples\Button\DroidButton.csproj]
W/ResourceType(23681): error APT0000: For resource 0x0101053e, entry index(1342) is beyond type entryCount(733) [C:\Users\peter\source\monodroid-samples\Button\DroidButton.csproj]
W/ResourceType(23681): error APT0000: For resource 0x0101053b, entry index(1339) is beyond type entryCount(733) [C:\Users\peter\source\monodroid-samples\Button\DroidButton.csproj]
W/ResourceType(23681): error APT0000: For resource 0x0101053c, entry index(1340) is beyond type entryCount(733) [C:\Users\peter\source\monodroid-samples\Button\DroidButton.csproj]
Done executing task "Aapt2Link" -- FAILED. (TaskId:97)

Version Information

https://gist.github.com/pjcollins/220d551af40c4ccc18db3e7df0c1b72f

Log File

https://gist.github.com/pjcollins/57dec1bd340d9212129c1d8a0a779433

VS bug #624789

[atsushieno]

Should we still support targetSdkVersion < 26 while Google Play will start rejecting such apks from August 2018?

[pjcollins]

@dellis1972 when building a similar project in Android Studio this particular message is also generated and displayed. However, in their case, it's is seemingly only perceived as a warning and is non fatal:

:app:processDebugResources (Thread[Daemon worker Thread 7,5,main]) started.
:app:processDebugResources
Task ':app:processDebugResources' is not up-to-date because:
  Value of input property 'buildTargetDensity' has changed for task ':app:processDebugResources'
All input files are considered out-of-date for incremental task ':app:processDebugResources'.
Unable do incremental execution: full task run
W/ResourceType( 2584): For resource 0x0101053d, entry index(1341) is beyond type entryCount(1112)
W/ResourceType( 2584): For resource 0x0101053e, entry index(1342) is beyond type entryCount(1112)
W/ResourceType( 2584): For resource 0x0101053b, entry index(1339) is beyond type entryCount(1112)
W/ResourceType( 2584): For resource 0x0101053c, entry index(1340) is beyond type entryCount(1112)

Aapt output file C:\Users\peter\AndroidStudioProjects\NoLibsTest\app\build\intermediates\processed_res\debug\processDebugResources\out\resources-debug.ap_
:app:processDebugResources (Thread[Daemon worker Thread 7,5,main]) completed. Took 0.164 secs.

[dellis1972]

@pjcollins hmm interesting. time to search in the aapt2 sources I guess.

[dellis1972]

I can't find that message in any of the aapt or aapt2 sources. :(

[dellis1972]

It does seem to be a warning though, so I guess we need to filter the error output for warnings which I was hoping we would not have to do :'(

[dellis1972]

Found the offending line [1]. It uses the ALOGW macro which confirms its a warning not an error, even though it is being written to stderr.

[1] https://github.com/aosp-mirror/platform_frameworks_base/blob/07735797a235ed98d182d0a40c8bdce4d92f9f0a/libs/androidfw/ResourceTypes.cpp#L6127