[build] Fix the MSBuild build #1232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The [`msbuild`-based Jenkins job][jenkins-msbuild] job has been failing a lot recently: [jenkins-msbuild]: https://jenkins.mono-project.com/view/Xamarin.Android/job/xamarin-android-msbuild/ error MSB3644: The reference assemblies for framework "MonoAndroid,Version=v1.0" were not found. The cause of the error is that *when there is no prebuilt mono runtime to download*, this file does not exist: bin/Debug/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/RedistList/FrameworkList.xml The above file is created by the `build-tools/scripts/mono-runtimes.mdproj` build, and `mono-runtimes.mdproj` *is not being built*. Without a mono build, there is no `MonoAndroid/v1.0` framework, and everything fails. I don't know when this actually broke, or what change is responsible. (It works with `xbuild`!) Attempt to improve reliability by adding `mono-runtimes.mdproj` to `$(MSBUILD_PREPARE_PROJS)`. This will cause the `msbuild`-based build to explicitly build `mono-runtimes.mdproj` *before* attempting to build `Xamarin.Android.Build.Tasks.csproj` or `Xamarin.Android.sln`.
grendello
approved these changes
Jan 25, 2018
jonpryor
pushed a commit
that referenced
this pull request
Nov 30, 2021
Context: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1397171 Context: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1433453 Changes: xamarin/monodroid@4e8702a...06ff96d * xamarin/monodroid@06ff96ddc: Bump to xamarin/androidtools@802ead1c, android-sdk-installer@01b73d23 (#1232) * xamarin/monodroid@42fef41af: Bump to 0503d63 (#1231)
jonathanpeppers
pushed a commit
that referenced
this pull request
Nov 30, 2021
Context: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1397171 Context: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1433453 Changes: xamarin/monodroid@4e8702a...06ff96d * xamarin/monodroid@06ff96ddc: Bump to xamarin/androidtools@802ead1c, android-sdk-installer@01b73d23 (#1232) * xamarin/monodroid@42fef41af: Bump to 0503d63 (#1231)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
msbuild-based Jenkins job job has beenfailing a lot recently:
The cause of the error is that when there is no prebuilt mono runtime
to download, this file does not exist:
The above file is created by the
build-tools/scripts/mono-runtimes.mdprojbuild, andmono-runtimes.mdprojis not being built. Without a mono build,there is no
MonoAndroid/v1.0framework, and everything fails.I don't know when this actually broke, or what change is responsible.
(It works with
xbuild!)Attempt to improve reliability by adding
mono-runtimes.mdprojto$(MSBUILD_PREPARE_PROJS). This will cause themsbuild-based buildto explicitly build
mono-runtimes.mdprojbefore attempting tobuild
Xamarin.Android.Build.Tasks.csprojorXamarin.Android.sln.