Use complete Java.Interop #1231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please make sure #1230 is merged and built before merging this PR. |
jonpryor
reviewed
Jan 24, 2018
|
|
||
| public override void WaitForGCBridgeProcessing () | ||
| { | ||
| throw new NotImplementedException (); |
There was a problem hiding this comment.
This can call JNIEnv.WaitForBridgeProcessing().
There was a problem hiding this comment.
OK, I will add it. Looks like it is not called yet though.
jonpryor
reviewed
Jan 24, 2018
| if (targetType == null) | ||
| return o.Instance; | ||
| return Convert.ChangeType (o.Instance, targetType); | ||
| return Convert.ChangeType(o.Instance, targetType); |
There was a problem hiding this comment.
Strange whitespace changes...
There was a problem hiding this comment.
Ops, VS formatting :-)
jonpryor
reviewed
Jan 24, 2018
| BeforeTargets="BeforeResolveReferences" | ||
| Inputs="$(JavaInteropFullPath)\src\Java.Interop\Java.Interop.csproj" | ||
| Outputs="$(OutputPath)\..\v1.0\Java.Interop.dll"> | ||
| <MSBuild |
There was a problem hiding this comment.
Ideally, we shouldn't need this <MSBuild/> invocation anymore, nor the _BuildJavaInterop target, nor the @(Assembly) item group (below).
Instead -- ideally -- we'd have a @(ProjectReference) within Mono.Android.csproj referring to Java.Interop.csproj, and MSBuild would handle it "normally".
There was a problem hiding this comment.
OK, I will try it in the next PR.
Start using complete Java.Interop, ie. `Debug` and `Release` configurations instead of `XAIntegrationDebug` and `XAIntegrationRelease`. Add Java.Interop java sources to the list of sources to build mono.android.jar. This is needed for `ManagedPeer` and other classes with java counterparts. Few updates to distinguish between `Android.Runtime.JavaObject` and `Java.Interop.JavaObject`. Added System.Collections reference is for `List<JniSurfacedPeerInfo>` return type in `AndroidValueManager`.
radekdoulik
force-pushed
the
pr-use-complete-java-interop
branch
from
4716fed to
c9f9dce
Compare
|
@monojenkins build Ubuntu+xbuild PR Build |
jonathanpeppers
added a commit
to jonathanpeppers/java.interop
that referenced
this pull request
Aug 23, 2018
In PR: dotnet#360 I will likely add a new `$(Configuration)` to be used in xamarin-android, so we can build `Java.Interop` as a non-PCL. The existence of `XAIntegrationDebug` and `XAIntegrationRelease` are confusing, since they are no longer used. See: dotnet@54a2aff dotnet/android#1231 This removes `XAIntegrationDebug` and `XAIntegrationRelease` from all solutions and project files. I also let VS 2017 update the SLN file, as it was an old VS 2010 format...
jonathanpeppers
added a commit
to jonathanpeppers/java.interop
that referenced
this pull request
Aug 23, 2018
In PR: dotnet#360 I will likely add a new `$(Configuration)` to be used in xamarin-android, so we can build `Java.Interop` as a non-PCL. The existence of `XAIntegrationDebug` and `XAIntegrationRelease` are confusing, since they are no longer used. See: dotnet@54a2aff dotnet/android#1231 This removes `XAIntegrationDebug` and `XAIntegrationRelease` from all solutions, project files, and `Makefile`. I also let VS 2017 update the SLN file, as it was an old VS 2010 format...
jonathanpeppers
added a commit
to jonathanpeppers/java.interop
that referenced
this pull request
Aug 24, 2018
In PR: dotnet#360 I will likely add a new `$(Configuration)` to be used in xamarin-android, so we can build `Java.Interop` as a non-PCL. The existence of `XAIntegrationDebug` and `XAIntegrationRelease` are confusing, since they are no longer used. See: dotnet@54a2aff dotnet/android#1231 This removes `XAIntegrationDebug` and `XAIntegrationRelease` from all solutions, project files, and `Makefile`. I also let VS 2017 update the SLN file, as it was an old VS 2010 format...
dellis1972
pushed a commit
to dotnet/java-interop
that referenced
this pull request
Aug 24, 2018
In PR: #360 I will likely add a new `$(Configuration)` to be used in xamarin-android, so we can build `Java.Interop` as a non-PCL. The existence of `XAIntegrationDebug` and `XAIntegrationRelease` are confusing, since they are no longer used. See: 54a2aff dotnet/android#1231 This removes `XAIntegrationDebug` and `XAIntegrationRelease` from all solutions, project files, and `Makefile`. I also let VS 2017 update the SLN file, as it was an old VS 2010 format...
jonathanpeppers
added a commit
to jonathanpeppers/java.interop
that referenced
this pull request
Sep 7, 2018
In PR: dotnet#360 I will likely add a new `$(Configuration)` to be used in xamarin-android, so we can build `Java.Interop` as a non-PCL. The existence of `XAIntegrationDebug` and `XAIntegrationRelease` are confusing, since they are no longer used. See: dotnet@54a2aff dotnet/android#1231 This removes `XAIntegrationDebug` and `XAIntegrationRelease` from all solutions, project files, and `Makefile`. I also let VS 2017 update the SLN file, as it was an old VS 2010 format...
jonpryor
pushed a commit
that referenced
this pull request
Nov 30, 2021
Context: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1397171 Context: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1433453 Changes: xamarin/monodroid@4e8702a...06ff96d * xamarin/monodroid@06ff96ddc: Bump to xamarin/androidtools@802ead1c, android-sdk-installer@01b73d23 (#1232) * xamarin/monodroid@42fef41af: Bump to 0503d63 (#1231)
jonathanpeppers
pushed a commit
that referenced
this pull request
Nov 30, 2021
Context: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1397171 Context: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1433453 Changes: xamarin/monodroid@4e8702a...06ff96d * xamarin/monodroid@06ff96ddc: Bump to xamarin/androidtools@802ead1c, android-sdk-installer@01b73d23 (#1232) * xamarin/monodroid@42fef41af: Bump to 0503d63 (#1231)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start using complete Java.Interop, ie.
DebugandReleaseconfigurations instead of
XAIntegrationDebugandXAIntegrationRelease.Add Java.Interop java sources to the list of sources to build
mono.android.jar. This is needed for
ManagedPeerand other classeswith java counterparts.
Few updates to distinguish between
Android.Runtime.JavaObjectandJava.Interop.JavaObject.Added System.Collections reference is for
List<JniSurfacedPeerInfo>return type in
AndroidValueManager.