Bump to xamarin/xamarin-android-tools:master@917d3b3c

Context: https://paper.dropbox.com/doc/OpenJDK-and-You--AH1yWKdVXgno~uXYfmcUAZTwAg-NoECAe2XkBQeoxFfGL6ea
Context: dotnet/android-tools#29 (comment)
Context: #2004 (comment)
Context: https://github.com/xamarin/xamarin-android-tools/blob/917d3b3ce455eed6a4a0e4271d34661bdf0b261d/src/Xamarin.Android.Tools.AndroidSdk/JdkInfo.cs#L256

Fixes: http://work.devdiv.io/646086
Fixes: http://work.devdiv.io/652760
Fixes: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/597752
Fixes: dotnet/android-tools#26
Fixes: dotnet/android-tools#39

Update & export `%JAVA_HOME%`, `%PATH%` on Windows.

We are [observing some unit test failures in this bump][0], which
[appear to be machine-specific][1].  We still don't understand the
cause of the unit test failures, so to assist in the eventual tracking
of this issue there is some additional, conditional, debug spew.

[0]: #2004 (comment)
[1]: #2004 (comment)

Author: jonpryor

external/xamarin-android-tools

@@ -55,8 +55,15 @@ public class ResolveSdks : Task
 		[Output]
 		public string MonoAndroidBinPath { get; set; }
 
+		static  readonly    string  GetMacOSMicrosoftJdkPathsOverrideName   = $"GetMacOSMicrosoftJdkPaths jdks override! {typeof (Xamarin.Android.Tools.JdkInfo).AssemblyQualifiedName}";
+
 		public override bool Execute ()
 		{
+			object shouldNotBeSet = AppDomain.CurrentDomain.GetData (GetMacOSMicrosoftJdkPathsOverrideName);
+			if (shouldNotBeSet != null) {
+				Log.LogMessage (MessageImportance.High, "{0}", $"AndroidSdkInfo unit test AppDomain key is set: {shouldNotBeSet}");
+			}
+
 			// OS X:    $prefix/lib/xamarin.android/xbuild/Xamarin/Android
 			// Windows: %ProgramFiles(x86)%\MSBuild\Xamarin\Android
 			if (string.IsNullOrEmpty (MonoAndroidToolsPath)) {

src/Xamarin.Android.Build.Tasks/Tasks/ResolveSdksTask.cs

@@ -208,9 +208,12 @@ public void ExplicitPackageNamingPolicy ()
 			}
 		}
 
+		static  readonly    string  GetMacOSMicrosoftJdkPathsOverrideName   = "GetMacOSMicrosoftJdkPaths jdks override! Xamarin.Android.Tools.JdkInfo, Xamarin.Android.Tools.AndroidSdk, Version=1.0.0.0, Culture=neutral, PublicKeyToken=84e04ff9cfb79065";
+
 		[Test]
 		public void CheckSignApk ([Values(true, false)] bool useApkSigner, [Values(true, false)] bool perAbiApk)
 		{
+			Console.WriteLine ($"# jonp: CheckSignApk({useApkSigner}, {perAbiApk}): JDKs overridden? {AppDomain.CurrentDomain.GetData (GetMacOSMicrosoftJdkPathsOverrideName)}");
 			string ext = Environment.OSVersion.Platform != PlatformID.Unix ? ".bat" : "";
 			var foundApkSigner = Directory.EnumerateDirectories (Path.Combine (AndroidSdkPath, "build-tools")).Any (dir => Directory.EnumerateFiles (dir, "apksigner"+ ext).Any ());
 			if (useApkSigner && !foundApkSigner) {
@@ -229,10 +232,15 @@ public void CheckSignApk ([Values(true, false)] bool useApkSigner, [Values(true,
 			using (var b = CreateApkBuilder (Path.Combine ("temp", TestContext.CurrentContext.Test.Name))) {
 				b.Verbosity = Microsoft.Build.Framework.LoggerVerbosity.Diagnostic;
 				Assert.IsTrue (b.Build (proj), "build failed");
-				Assert.IsTrue (StringAssertEx.ContainsText (b.LastBuildOutput, " 0 Warning(s)"));
+				if (!StringAssertEx.ContainsText (b.LastBuildOutput, " 0 Warning(s)")) {
+					Console.WriteLine ($"-- BEGIN CheckSignApk({useApkSigner}, {perAbiApk}) output--");
+					Console.WriteLine (b.LastBuildOutput);
+					Console.WriteLine ($"--   END CheckSignApk({useApkSigner}, {perAbiApk}) output--");
+				}
+				Assert.IsTrue (StringAssertEx.ContainsText (b.LastBuildOutput, " 0 Warning(s)"), "First build should not contain warnings!");
 				proj.AndroidResources.First ().Timestamp = null;
 				Assert.IsTrue (b.Build (proj), "Second build failed");
-				Assert.IsTrue (StringAssertEx.ContainsText (b.LastBuildOutput, " 0 Warning(s)"));
+				Assert.IsTrue (StringAssertEx.ContainsText (b.LastBuildOutput, " 0 Warning(s)"), "Second build should not contain warnings!");
 			}
 		}