-
Notifications
You must be signed in to change notification settings - Fork 31
Jdk properties are required for external clients to make environment … #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…decisions and informs environment details JdkProperties get the jdk properties for a given JDK path. For the moment we are returning values for vendor and java version.
|
Conceptually, what we'd prefer to do is "import" this file: presumably as public class JdkInfo {
public JdkInfo (string jdkRoot);
public string JavaHome {get;}
public string Vendor {get;}
public Version Version {get;}
public static IEnumerable<JdkInfo> GetInstalledJdks (params string[] jdkRoots);
}(This will require a fair bit of refactoring, but it looks plausible/straightforward.) |
jonpryor
added a commit
to jonpryor/xamarin-android-tools
that referenced
this pull request
Jul 24, 2018
Context: dotnet#29 (comment) Refactor out the [underlying functionality][0] of the [`<JdkInfo/>` task][1] so that it is more easily usable. [0]: dotnet/java-interop@4bd9297 [1]: https://github.com/xamarin/java.interop/blob/master/src/Java.Interop.BootstrapTasks/Java.Interop.BootstrapTasks/JdkInfo.cs
jonpryor
added a commit
to jonpryor/xamarin-android-tools
that referenced
this pull request
Jul 24, 2018
Context: dotnet#29 (comment) Refactor out the [underlying functionality][0] of the [`<JdkInfo/>` task][1] so that it is more easily usable. [0]: dotnet/java-interop@4bd9297 [1]: https://github.com/xamarin/java.interop/blob/master/src/Java.Interop.BootstrapTasks/Java.Interop.BootstrapTasks/JdkInfo.cs
jonpryor
added a commit
to jonpryor/xamarin-android-tools
that referenced
this pull request
Jul 24, 2018
Context: dotnet#29 (comment) Refactor out the [underlying functionality][0] of the [`<JdkInfo/>` task][1] so that it is more easily usable. [0]: dotnet/java-interop@4bd9297 [1]: https://github.com/xamarin/java.interop/blob/master/src/Java.Interop.BootstrapTasks/Java.Interop.BootstrapTasks/JdkInfo.cs
jonpryor
added a commit
to jonpryor/xamarin-android-tools
that referenced
this pull request
Jul 24, 2018
Context: dotnet#29 (comment) Refactor out the [underlying functionality][0] of the [`<JdkInfo/>` task][1] so that it is more easily usable. [0]: dotnet/java-interop@4bd9297 [1]: https://github.com/xamarin/java.interop/blob/master/src/Java.Interop.BootstrapTasks/Java.Interop.BootstrapTasks/JdkInfo.cs
jonpryor
added a commit
to jonpryor/xamarin-android-tools
that referenced
this pull request
Jul 24, 2018
Context: dotnet#29 (comment) Refactor out the [underlying functionality][0] of the [`<JdkInfo/>` task][1] so that it is more easily usable. [0]: dotnet/java-interop@4bd9297 [1]: https://github.com/xamarin/java.interop/blob/master/src/Java.Interop.BootstrapTasks/Java.Interop.BootstrapTasks/JdkInfo.cs
jonpryor
added a commit
to jonpryor/xamarin-android-tools
that referenced
this pull request
Jul 25, 2018
Context: dotnet#29 (comment) Refactor out the [underlying functionality][0] of the [`<JdkInfo/>` task][1] so that it is more easily usable. [0]: dotnet/java-interop@4bd9297 [1]: https://github.com/xamarin/java.interop/blob/master/src/Java.Interop.BootstrapTasks/Java.Interop.BootstrapTasks/JdkInfo.cs
jonpryor
added a commit
to jonpryor/xamarin-android-tools
that referenced
this pull request
Jul 25, 2018
Fixes: dotnet#26 Context: dotnet#29 (comment) Refactor out the [underlying functionality][0] of the [`<JdkInfo/>` task][1] so that it is more easily usable. [0]: dotnet/java-interop@4bd9297 [1]: https://github.com/xamarin/java.interop/blob/master/src/Java.Interop.BootstrapTasks/Java.Interop.BootstrapTasks/JdkInfo.cs
jonpryor
added a commit
to jonpryor/xamarin-android-tools
that referenced
this pull request
Jul 25, 2018
Fixes: dotnet#26 Context: dotnet#29 (comment) Refactor out the [underlying functionality][0] of the [`<JdkInfo/>` task][1] so that it is more easily usable. [0]: dotnet/java-interop@4bd9297 [1]: https://github.com/xamarin/java.interop/blob/master/src/Java.Interop.BootstrapTasks/Java.Interop.BootstrapTasks/JdkInfo.cs
jonpryor
added a commit
to dotnet/android
that referenced
this pull request
Jul 26, 2018
Context: https://paper.dropbox.com/doc/OpenJDK-and-You--AH1yWKdVXgno~uXYfmcUAZTwAg-NoECAe2XkBQeoxFfGL6ea Context: dotnet/android-tools#29 (comment) Fixes: http://work.devdiv.io/646086 Fixes: http://work.devdiv.io/652760 Fixes: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/597752 Fixes: dotnet/android-tools#26 Update & export `%JAVA_HOME%`, `%PATH%` on Windows. Support a Microsoft
jonpryor
added a commit
to dotnet/android
that referenced
this pull request
Jul 26, 2018
Context: https://paper.dropbox.com/doc/OpenJDK-and-You--AH1yWKdVXgno~uXYfmcUAZTwAg-NoECAe2XkBQeoxFfGL6ea Context: dotnet/android-tools#29 (comment) Fixes: http://work.devdiv.io/646086 Fixes: http://work.devdiv.io/652760 Fixes: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/597752 Fixes: dotnet/android-tools#26 Update & export `%JAVA_HOME%`, `%PATH%` on Windows.
jonpryor
added a commit
to jonpryor/java.interop
that referenced
this pull request
Jul 26, 2018
Context: dotnet/android-tools#29 (comment) Bumps to xamarin/xamarin-android-tools:master@75530565 The `<JdkInfo/>` task within `Java.Interop.BootstrapTasks.dll` isn't the *only* thing that needs to determine the path of an installed JDK. The IDEs could also use such functionality, as could xamarin-android. Add a submodule reference to xamarin-android-tools, and use `Xamarin.Android.Tools.JdkInfo` to find the preferred JDK, instead of having lots of custom probing with the `<JdkInfo/>` task. Finally, for consistency, move `src/Java.Interop.BootstrapTasks` to `build-tools/Java.Interop.BootstrapTasks`, as the `Java.Interop.BootstrapTasks.dll` assembly is only intended for in building Java.Interop *itself*, and not for "downlevel" distribution.
jonpryor
added a commit
to jonpryor/java.interop
that referenced
this pull request
Jul 27, 2018
Context: dotnet/android-tools#29 (comment) Bumps to xamarin/xamarin-android-tools:master@75530565 The `<JdkInfo/>` task within `Java.Interop.BootstrapTasks.dll` isn't the *only* thing that needs to determine the path of an installed JDK. The IDEs could also use such functionality, as could xamarin-android. Add a submodule reference to xamarin-android-tools, and use `Xamarin.Android.Tools.JdkInfo` to find the preferred JDK, instead of having lots of custom probing with the `<JdkInfo/>` task. Finally, for consistency, move `src/Java.Interop.BootstrapTasks` to `build-tools/Java.Interop.BootstrapTasks`, as the `Java.Interop.BootstrapTasks.dll` assembly is only intended for in building Java.Interop *itself*, and not for "downlevel" distribution.
jonpryor
added a commit
to dotnet/android
that referenced
this pull request
Jul 27, 2018
Context: https://paper.dropbox.com/doc/OpenJDK-and-You--AH1yWKdVXgno~uXYfmcUAZTwAg-NoECAe2XkBQeoxFfGL6ea Context: dotnet/android-tools#29 (comment) Fixes: http://work.devdiv.io/646086 Fixes: http://work.devdiv.io/652760 Fixes: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/597752 Fixes: dotnet/android-tools#26 Update & export `%JAVA_HOME%`, `%PATH%` on Windows.
jonpryor
added a commit
to jonpryor/java.interop
that referenced
this pull request
Jul 27, 2018
Context: dotnet/android-tools#29 (comment) Bumps to xamarin/xamarin-android-tools:master@75530565 The `<JdkInfo/>` task within `Java.Interop.BootstrapTasks.dll` isn't the *only* thing that needs to determine the path of an installed JDK. The IDEs could also use such functionality, as could xamarin-android. Add a submodule reference to xamarin-android-tools, and use `Xamarin.Android.Tools.JdkInfo` to find the preferred JDK, instead of having lots of custom probing with the `<JdkInfo/>` task. Finally, for consistency, move `src/Java.Interop.BootstrapTasks` to `build-tools/Java.Interop.BootstrapTasks`, as the `Java.Interop.BootstrapTasks.dll` assembly is only intended for in building Java.Interop *itself*, and not for "downlevel" distribution.
jonpryor
added a commit
to dotnet/java-interop
that referenced
this pull request
Jul 27, 2018
Context: dotnet/android-tools#29 (comment) Bumps to xamarin/xamarin-android-tools:master@75530565 The `<JdkInfo/>` task within `Java.Interop.BootstrapTasks.dll` isn't the *only* thing that needs to determine the path of an installed JDK. The IDEs could also use such functionality, as could xamarin-android. Add a submodule reference to xamarin-android-tools, and use `Xamarin.Android.Tools.JdkInfo` to find the preferred JDK, instead of having lots of custom probing with the `<JdkInfo/>` task. Finally, for consistency, move `src/Java.Interop.BootstrapTasks` to `build-tools/Java.Interop.BootstrapTasks`, as the `Java.Interop.BootstrapTasks.dll` assembly is only intended for in building Java.Interop *itself*, and not for "downlevel" distribution.
jonpryor
added a commit
to dotnet/android
that referenced
this pull request
Aug 2, 2018
Context: https://paper.dropbox.com/doc/OpenJDK-and-You--AH1yWKdVXgno~uXYfmcUAZTwAg-NoECAe2XkBQeoxFfGL6ea Context: dotnet/android-tools#29 (comment) Fixes: http://work.devdiv.io/646086 Fixes: http://work.devdiv.io/652760 Fixes: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/597752 Fixes: dotnet/android-tools#26 Fixes: dotnet/android-tools#39 Update & export `%JAVA_HOME%`, `%PATH%` on Windows.
jonpryor
added a commit
to dotnet/android
that referenced
this pull request
Aug 2, 2018
Context: https://paper.dropbox.com/doc/OpenJDK-and-You--AH1yWKdVXgno~uXYfmcUAZTwAg-NoECAe2XkBQeoxFfGL6ea Context: dotnet/android-tools#29 (comment) Fixes: http://work.devdiv.io/646086 Fixes: http://work.devdiv.io/652760 Fixes: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/597752 Fixes: dotnet/android-tools#26 Fixes: dotnet/android-tools#39 Update & export `%JAVA_HOME%`, `%PATH%` on Windows.
jonpryor
added a commit
to dotnet/android
that referenced
this pull request
Aug 2, 2018
Context: https://paper.dropbox.com/doc/OpenJDK-and-You--AH1yWKdVXgno~uXYfmcUAZTwAg-NoECAe2XkBQeoxFfGL6ea Context: dotnet/android-tools#29 (comment) Fixes: http://work.devdiv.io/646086 Fixes: http://work.devdiv.io/652760 Fixes: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/597752 Fixes: dotnet/android-tools#26 Fixes: dotnet/android-tools#39 Update & export `%JAVA_HOME%`, `%PATH%` on Windows.
jonpryor
added a commit
to dotnet/android
that referenced
this pull request
Aug 2, 2018
Context: https://paper.dropbox.com/doc/OpenJDK-and-You--AH1yWKdVXgno~uXYfmcUAZTwAg-NoECAe2XkBQeoxFfGL6ea Context: dotnet/android-tools#29 (comment) Context: #2004 (comment) Fixes: http://work.devdiv.io/646086 Fixes: http://work.devdiv.io/652760 Fixes: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/597752 Fixes: dotnet/android-tools#26 Fixes: dotnet/android-tools#39 Update & export `%JAVA_HOME%`, `%PATH%` on Windows. We are [observing some unit test failures in this bump][0], which [appear to be machine-specific][1]. We still don't understand the cause of the unit test failures, so to assist in the eventual tracking of this issue there is some additional, conditional, debug spew. [0]: #2004 (comment) [1]: #2004 (comment)
jonpryor
added a commit
to dotnet/android
that referenced
this pull request
Aug 2, 2018
Context: https://paper.dropbox.com/doc/OpenJDK-and-You--AH1yWKdVXgno~uXYfmcUAZTwAg-NoECAe2XkBQeoxFfGL6ea Context: dotnet/android-tools#29 (comment) Context: #2004 (comment) Context: https://github.com/xamarin/xamarin-android-tools/blob/917d3b3ce455eed6a4a0e4271d34661bdf0b261d/src/Xamarin.Android.Tools.AndroidSdk/JdkInfo.cs#L256 Fixes: http://work.devdiv.io/646086 Fixes: http://work.devdiv.io/652760 Fixes: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/597752 Fixes: dotnet/android-tools#26 Fixes: dotnet/android-tools#39 Update & export `%JAVA_HOME%`, `%PATH%` on Windows. We are [observing some unit test failures in this bump][0], which [appear to be machine-specific][1]. We still don't understand the cause of the unit test failures, so to assist in the eventual tracking of this issue there is some additional, conditional, debug spew. [0]: #2004 (comment) [1]: #2004 (comment)
jonpryor
added a commit
that referenced
this pull request
Aug 2, 2018
Fixes: #26 Context: #29 (comment) Refactor out the [underlying functionality][0] of the [`<JdkInfo/>` task][1] so that it is more easily usable. [0]: dotnet/java-interop@4bd9297 [1]: https://github.com/xamarin/java.interop/blob/master/src/Java.Interop.BootstrapTasks/Java.Interop.BootstrapTasks/JdkInfo.cs
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Aug 2, 2018
Context: https://paper.dropbox.com/doc/OpenJDK-and-You--AH1yWKdVXgno~uXYfmcUAZTwAg-NoECAe2XkBQeoxFfGL6ea Context: dotnet/android-tools#29 (comment) Fixes: http://work.devdiv.io/646086 Fixes: http://work.devdiv.io/652760 Fixes: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/597752 Fixes: dotnet/android-tools#26 Fixes: dotnet/android-tools#39 Update & export `%JAVA_HOME%`, `%PATH%` on Windows.
jonpryor
added a commit
to dotnet/android
that referenced
this pull request
Aug 3, 2018
…c890a35ce3a8751316c1f829566e57 Context: https://paper.dropbox.com/doc/OpenJDK-and-You--AH1yWKdVXgno~uXYfmcUAZTwAg-NoECAe2XkBQeoxFfGL6ea Context: dotnet/android-tools#29 (comment) Context: #2004 (comment) Context: https://github.com/xamarin/xamarin-android-tools/blob/917d3b3ce455eed6a4a0e4271d34661bdf0b261d/src/Xamarin.Android.Tools.AndroidSdk/JdkInfo.cs#L256 Fixes: http://work.devdiv.io/646086 Fixes: http://work.devdiv.io/652760 Fixes: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/597752 Fixes: dotnet/android-tools#26 Fixes: dotnet/android-tools#39 Update & export `%JAVA_HOME%`, `%PATH%` on Windows. We are [observing some unit test failures in this bump][0], which [appear to be machine-specific][1]. We still don't understand the cause of the unit test failures, so to assist in the eventual tracking of this issue there is some additional, conditional, debug spew. [0]: #2004 (comment) [1]: #2004 (comment) Also, MOAR INFO IN JDK ERROR MESSAGES.
jonpryor
added a commit
to dotnet/android
that referenced
this pull request
Aug 3, 2018
Context: https://paper.dropbox.com/doc/OpenJDK-and-You--AH1yWKdVXgno~uXYfmcUAZTwAg-NoECAe2XkBQeoxFfGL6ea Context: dotnet/android-tools#29 (comment) Context: #2004 (comment) Context: https://github.com/xamarin/xamarin-android-tools/blob/917d3b3ce455eed6a4a0e4271d34661bdf0b261d/src/Xamarin.Android.Tools.AndroidSdk/JdkInfo.cs#L256 Fixes: http://work.devdiv.io/646086 Fixes: http://work.devdiv.io/652760 Fixes: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/597752 Fixes: dotnet/android-tools#26 Fixes: dotnet/android-tools#39 Update & export `%JAVA_HOME%`, `%PATH%` on Windows.
jonpryor
added a commit
to dotnet/android
that referenced
this pull request
Aug 3, 2018
Context: https://paper.dropbox.com/doc/OpenJDK-and-You--AH1yWKdVXgno~uXYfmcUAZTwAg-NoECAe2XkBQeoxFfGL6ea Context: dotnet/android-tools#29 (comment) Fixes: http://work.devdiv.io/646086 Fixes: http://work.devdiv.io/652760 Fixes: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/597752 Fixes: dotnet/android-tools#26 Fixes: dotnet/android-tools#39 Update & export `%JAVA_HOME%`, `%PATH%` on Windows.
jonpryor
added a commit
to dotnet/android
that referenced
this pull request
Aug 3, 2018
Context: https://paper.dropbox.com/doc/OpenJDK-and-You--AH1yWKdVXgno~uXYfmcUAZTwAg-NoECAe2XkBQeoxFfGL6ea Context: dotnet/android-tools#29 (comment) Context: #2004 (comment) Context: https://github.com/xamarin/xamarin-android-tools/blob/917d3b3ce455eed6a4a0e4271d34661bdf0b261d/src/Xamarin.Android.Tools.AndroidSdk/JdkInfo.cs#L256 Fixes: http://work.devdiv.io/646086 Fixes: http://work.devdiv.io/652760 Fixes: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/597752 Fixes: dotnet/android-tools#26 Fixes: dotnet/android-tools#39 Update & export `%JAVA_HOME%`, `%PATH%` on Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…decisions and informs environment details
JdkProperties get the jdk properties for a given JDK path.
For the moment we are returning values for vendor and java version.