Commit 69d78d0
committed
[build] Include unit test logs in
The `xa-test-errors*.zip` files generated by
`make package-test-errors` only included "failing" *MSBuild* unit test
projects [^1]. This means that if there were unit test failures that
*didn't* have a corresponding MSBuild unit test, the only output that
*might* be useful were the `.binlog` files in in
`xa-build-status*.zip`.
Not all useful unit test output will be in the `.binlog` files.
Update `make package-test-errors` so that the `xa-test-errors*.zip`
file *also* contains the `TestResult-*.xml` NUnit output files and the
`bin/Test*/TestOutput-*.txt` files produced by NUnit test execution.
This allows observing e.g. `Console.WriteLine()` messages generated
when executing the unit tests.
[^1]: The *intent* for `make package-test-errors` was that it would
only produce file if there actually were failures, which is why
the target rules were conditional on `bin/Test*/temp` existing,
because that held the unit test-generated MSBuild projects.
However, that's *also* where the unit test-generated MSBuild
*NuGet packages* resided, in e.g. `bin/TestDebug/temp/packages`.
Nothing deletes the `packages` directory. Consequently,
`make package-test-errors` *always* generated an
`xa-test-errors*.zip` file, even when all tests passed!make package-test-errors
1 parent 221a219 commit 69d78d0
1 file changed
+1
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
66 | 66 | | |
67 | 67 | | |
68 | 68 | | |
69 | | - | |
70 | | - | |
| 69 | + | |
71 | 70 | | |
72 | | - | |
73 | 71 | | |
74 | 72 | | |
75 | 73 | | |
| |||
0 commit comments