feat: add hedgey shortcut for claiming #278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jeanregisser
left a comment
jeanregisser
left a comment
There was a problem hiding this comment.
Awesome!
Would it be possible to add an e2e test for the shortcut? Just to check we can get the full definition.
src/apps/hedgey/positions.ts
Outdated
| tokens: [{ address: tokenAddress, network }], | ||
| tokens: [{ address: tokenAddress, network, category: 'claimable' }], | ||
| availableShortcutIds: [ | ||
| `${planNft.contractAddress},${planNft.tokenId}`, |
Member
There was a problem hiding this comment.
nit: I like using : in more semantic IDs
Suggested change
| `${planNft.contractAddress},${planNft.tokenId}`, | |
| `${planNft.contractAddress}:${planNft.tokenId}`, |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #278 +/- ##
==========================================
+ Coverage 92.81% 92.98% +0.16%
==========================================
Files 35 36 +1
Lines 668 684 +16
Branches 65 66 +1
==========================================
+ Hits 620 636 +16
Misses 45 45
Partials 3 3
Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.