refactor(getShortcutDefinitions): define to return a promise #277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #277 +/- ##
=======================================
Coverage 92.81% 92.81%
=======================================
Files 35 35
Lines 668 668
Branches 65 65
=======================================
Hits 620 620
Misses 45 45
Partials 3 3
Continue to review full report in Codecov by Sentry.
|
Contributor
Author
|
There's this guy in the pipeline, fyi: #278 |
jeanregisser
approved these changes
Dec 11, 2023
src/apps/gooddollar/shortcuts.ts
Outdated
Comment on lines
12
to
13
| getShortcutDefinitions(_network?: string, _address?: string) { | ||
| return [ | ||
| return Promise.resolve([ |
Member
There was a problem hiding this comment.
This works, but why not turning adding the async keyword to the function instead?
Feels simpler.
Contributor
Author
There was a problem hiding this comment.
Meh, it felt superfluous because we don't use the await keyword. I can change it.
The runtime already resolves the value .getShortcutDefinitions returns.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The runtime already resolves the value .getShortcutDefinitions returns.