refactor(GatewayIdentifyProperties): remove $ prefix from keys
#493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
requested review from
SpaceEEC,
iCrawl,
kyranet and
vladfrangu
vladfrangu
approved these changes
Jun 14, 2022
kyranet
approved these changes
Jun 16, 2022
Contributor
|
The gateway still supports both types, should this be reflected here as well? |
Member
The other types are considered deprecated sooo, not really a point |
Member
Author
The upstream PR removed them completely, they weren't marked as deprecated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
If applicable, please reference Discord API Docs PRs or commits that influenced this PR:
Update identify payload discord/discord-api-docs#5058Updated identify connection fields to match deprecation status. discord/discord-api-docs#5067