Updated identify connection fields to match deprecation status. #5067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is expected that these field names will be supported for a while, but it is recommended to all consumers to update to unprefixed fields.
DV8FromTheWorld
commented
Jun 16, 2022
Contributor
Contributor
|
Would a deprecation like this not be deserving of a changelog entry? |
7 tasks
Member
Author
Yes, it deserves a changelog entry. I'm planning to include one in this PR. |
shaydewael
force-pushed
the
docs/update-identify-field
branch
from
2344c74 to
573da9a
Compare
This was referenced Jun 17, 2022
Zoddo
reviewed
Jun 17, 2022
Co-authored-by: Zoddo <[email protected]>
spring4175
pushed a commit
to twilight-rs/twilight
that referenced
this pull request
Jun 18, 2022
Remove the dollar sign renames in the identify fields now that they are deprecated: discord/discord-api-docs#5067
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is expected that these field names will be supported for a while, but it is recommended to all consumers to update to unprefixed fields.