Skip to content

Temporarily revert #6876 #7918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tautschnig
Copy link
Collaborator

As much as we would like to get rid of __CPROVER_allocated_memory, we don't currently have a replacement available. This PR removes the deprecation warning to reduce the noise for users who intentionally use this intrinsic. This is a clean revert of the two commit of #6876, and these two commits should be added back once we have a replacement.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig self-assigned this Sep 26, 2023
@tautschnig tautschnig force-pushed the cleanup/de-deprecate-allocated branch from d4f4f2c to dfe0d89 Compare September 26, 2023 18:46
@tautschnig tautschnig marked this pull request as ready for review September 26, 2023 18:46
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (e02fd74) 78.94% compared to head (dfe0d89) 79.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7918      +/-   ##
===========================================
+ Coverage    78.94%   79.00%   +0.06%     
===========================================
  Files         1697     1697              
  Lines       195379   195370       -9     
===========================================
+ Hits        154242   154357     +115     
+ Misses       41137    41013     -124     
Files Coverage Δ
src/ansi-c/goto_check_c.cpp 91.16% <ø> (-0.08%) ⬇️

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tautschnig tautschnig merged commit 10c4bca into diffblue:develop Sep 27, 2023
@tautschnig tautschnig deleted the cleanup/de-deprecate-allocated branch September 27, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants