Skip to content

Add deprecation warning for intrinsic __CPROVER_allocated_memory #6876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

NlightNFotis
Copy link
Contributor

@NlightNFotis NlightNFotis commented May 24, 2022

In line with #6872, this PR adds a deprecation warning for the usage of the intrinsic __CPROVER_allocated_memory.

Fixes: #6872

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link
Collaborator

@tautschnig tautschnig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might just use one of the existing tests that currently use __CPROVER_allocated_memory to add a pattern.

@codecov
Copy link

codecov bot commented May 24, 2022

Codecov Report

Merging #6876 (ece1a84) into develop (f7a33df) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #6876   +/-   ##
========================================
  Coverage    77.81%   77.81%           
========================================
  Files         1568     1568           
  Lines       179985   179994    +9     
========================================
+ Hits        140054   140063    +9     
  Misses       39931    39931           
Impacted Files Coverage Δ
src/ansi-c/goto_check_c.cpp 91.55% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bf3ea6...ece1a84. Read the comment docs.

@NlightNFotis
Copy link
Contributor Author

@tautschnig Yeah, that's what I was planning to do :)

Copy link
Contributor

@TGWDB TGWDB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to approve as is, but note that if we're starting to plan Version 6 changes and deprecations, we may want a macro or standard way to implement deprecation warnings.

@NlightNFotis
Copy link
Contributor Author

@kroening Hi Daniel, this is blocked on a code owner's review from you. Could you please have a look when you find some time? Thank you 👍🏻

@NlightNFotis NlightNFotis force-pushed the warn_allocated_memory_depracated branch from d585e7a to ece1a84 Compare May 31, 2022 09:32
@NlightNFotis NlightNFotis merged commit 2a64c19 into diffblue:develop May 31, 2022
@NlightNFotis NlightNFotis deleted the warn_allocated_memory_depracated branch May 31, 2022 12:32
@tautschnig tautschnig mentioned this pull request Sep 26, 2023
4 tasks
tautschnig added a commit that referenced this pull request Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate __CPROVER_allocated_memory
3 participants