-
Notifications
You must be signed in to change notification settings - Fork 275
Add deprecation warning for intrinsic __CPROVER_allocated_memory
#6876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deprecation warning for intrinsic __CPROVER_allocated_memory
#6876
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might just use one of the existing tests that currently use __CPROVER_allocated_memory
to add a pattern.
Codecov Report
@@ Coverage Diff @@
## develop #6876 +/- ##
========================================
Coverage 77.81% 77.81%
========================================
Files 1568 1568
Lines 179985 179994 +9
========================================
+ Hits 140054 140063 +9
Misses 39931 39931
Continue to review full report at Codecov.
|
@tautschnig Yeah, that's what I was planning to do :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to approve as is, but note that if we're starting to plan Version 6 changes and deprecations, we may want a macro or standard way to implement deprecation warnings.
@kroening Hi Daniel, this is blocked on a code owner's review from you. Could you please have a look when you find some time? Thank you 👍🏻 |
d585e7a
to
ece1a84
Compare
In line with #6872, this PR adds a deprecation warning for the usage of the intrinsic
__CPROVER_allocated_memory
.Fixes: #6872