Skip to content

CMake/macOS: upgrade minimum version to 10.15 [blocks: #6749] #6767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2022

Conversation

tautschnig
Copy link
Collaborator

This is consistent with the Makefile-based build system, which had this
updated in eebdba8.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

This is consistent with the Makefile-based build system, which had this
updated in eebdba8.
@codecov
Copy link

codecov bot commented Mar 25, 2022

Codecov Report

Merging #6767 (3108deb) into develop (57a8097) will increase coverage by 0.00%.
The diff coverage is 81.39%.

@@           Coverage Diff            @@
##           develop    #6767   +/-   ##
========================================
  Coverage    76.89%   76.90%           
========================================
  Files         1590     1590           
  Lines       183979   183965   -14     
========================================
+ Hits        141478   141479    +1     
+ Misses       42501    42486   -15     
Impacted Files Coverage Δ
...o-instrument/accelerate/polynomial_accelerator.cpp 0.00% <0.00%> (ø)
...oto-instrument/accelerate/polynomial_accelerator.h 100.00% <ø> (ø)
src/solvers/flattening/boolbv.h 62.50% <ø> (ø)
src/solvers/flattening/boolbv_overflow.cpp 48.68% <76.00%> (-1.91%) ⬇️
src/solvers/flattening/boolbv.cpp 80.39% <80.00%> (-0.18%) ⬇️
src/analyses/goto_rw.cpp 63.28% <100.00%> (+0.45%) ⬆️
src/goto-symex/goto_symex_state.cpp 91.71% <100.00%> (+0.04%) ⬆️
src/util/simplify_expr_array.cpp 90.72% <100.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb08494...3108deb. Read the comment docs.

Copy link
Contributor

@thomasspriggs thomasspriggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable.

@tautschnig tautschnig merged commit b04b4b5 into diffblue:develop Mar 29, 2022
@tautschnig tautschnig deleted the cleanup/cmake-10-15 branch March 29, 2022 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants