Skip to content

Do not use optionalt::value() [blocks: #6749] #6765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

tautschnig
Copy link
Collaborator

std::optional::value() is unavailable in earlier versions of macOS. We
generally use operator* already, which always works.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

std::optional::value() is unavailable in earlier versions of macOS. We
generally use operator* already, which always works.
@tautschnig tautschnig requested a review from kroening as a code owner March 25, 2022 13:06
@tautschnig tautschnig changed the title Do not use optionalt::value() Do not use optionalt::value() [blocks: #6749] Mar 25, 2022
@tautschnig
Copy link
Collaborator Author

Closing in favour of the much less intrusive #6767.

@tautschnig tautschnig closed this Mar 25, 2022
@tautschnig tautschnig deleted the cleanup/value branch March 25, 2022 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants