Skip to content

First set of fixes to Dockerhub push action. #5747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 14, 2021
Merged

First set of fixes to Dockerhub push action. #5747

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8569503
Disable the homebrew pr submitting temporarily.
NlightNFotis Jan 14, 2021
97c38a6
Add missing GITHUB_TOKEN to docker image push action.
NlightNFotis Jan 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/release-packages.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@ jobs:


homebrew-pr:
if: ${{ false }} # disable for now
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please immediately have a PR that will re-enable this (once the PR is merged)? I am very worried about us forgetting about this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can do that immediately then if that eases your mind (even though it's on my personal todo list as a step after getting it working, so I wouldn't forget about it).

I'll submit a new PR reversing this and link to it here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay the new PR is available at #5748.

Please do not merge it yet - I'll merge it when the dockerhub image push is ready.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @NlightNFotis for creating the follow-up PR!

runs-on: macos-10.15
steps:
- name: Get release tag name
Expand Down Expand Up @@ -209,6 +210,8 @@ jobs:

push-docker-image-dockerhub:
runs-on: ubuntu-20.04
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
steps:
- name: Checkout CBMC source
uses: actions/checkout@v2
Expand Down