Skip to content

First set of fixes to Dockerhub push action. #5747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 14, 2021
Merged

First set of fixes to Dockerhub push action. #5747

merged 2 commits into from
Jan 14, 2021

Conversation

NlightNFotis
Copy link
Contributor

This PR contains two small fixes to the Dockerhub image push action we wrote:

  1. Deactivates the Homebrew PR action temporarily, so that we don't spam it
    everytime we make a new experimental release.
  2. Adds a missing GITHUB_TOKEN within the scope of the Dockerhub image
    push action so it can have access to metadata required (release version) to
    name the docker image appropriately.
  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@NlightNFotis
Disable the homebrew pr submitting temporarily.
8569503 
Since it's an external repository, and we are in the
process of testing our submitting to dockerhub it
makes sense to temporarily disable it to avoid spamming
it with temporary/experimental PRs.
@NlightNFotis
Add missing GITHUB_TOKEN to docker image push action.
97c38a6 
Without this the get_release_info action is failing
as it doesn't have access to the github token that
gives it access to repository metadata.
@NlightNFotis NlightNFotis requested a review from a team as a code owner January 14, 2021 16:18
hannes-steffenhagen-diffblue
hannes-steffenhagen-diffblue approved these changes Jan 14, 2021
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disabling the homebrew PR isn't a "fix", but yes we should avoid spamming them.

@codecov
Copy link

codecov bot commented Jan 14, 2021 •
edited
Loading

Codecov Report

Merging #5747 (97c38a6) into develop (9f164e4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5747   +/-   ##
========================================
  Coverage    69.55%   69.55%           
========================================
  Files         1243     1243           
  Lines       100793   100793           
========================================
  Hits         70108    70108           
  Misses       30685    30685
Flag Coverage Δ
cproversmt2 43.33% <ø> (ø)
regression 66.45% <ø> (ø)
unit 32.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f164e4...97c38a6. Read the comment docs.

@NlightNFotis NlightNFotis merged commit 431acd6 into diffblue:develop Jan 14, 2021
@NlightNFotis NlightNFotis deleted the dockerhub_push_fix_1 branch January 14, 2021 17:33
tautschnig
tautschnig reviewed Jan 14, 2021
View reviewed changes
.github/workflows/release-packages.yaml
@@ -118,6 +118,7 @@ jobs:


homebrew-pr:
if: ${{ false }} # disable for now
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please immediately have a PR that will re-enable this (once the PR is merged)? I am very worried about us forgetting about this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can do that immediately then if that eases your mind (even though it's on my personal todo list as a step after getting it working, so I wouldn't forget about it).

I'll submit a new PR reversing this and link to it here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay the new PR is available at #5748.

Please do not merge it yet - I'll merge it when the dockerhub image push is ready.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @NlightNFotis for creating the follow-up PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tautschnig tautschnig tautschnig left review comments

@hannes-steffenhagen-diffblue hannes-steffenhagen-diffblue hannes-steffenhagen-diffblue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NlightNFotis @tautschnig @hannes-steffenhagen-diffblue